Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @google-cloud/translate to v4 #1280

Merged
merged 4 commits into from
Aug 1, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 13, 2019

This PR contains the following updates:

Package Type Update Change References
@​google-cloud/translate dependencies major ^3.0.0 -> ^4.0.0 source

Release Notes

googleapis/nodejs-translate

v4.0.0

Compare Source

Bug Fixes
Build System
BREAKING CHANGES
  • upgrade engines field to >=8.10.0 (#​249)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@renovate renovate bot force-pushed the renovate/google-cloud-translate-4.x branch 4 times, most recently from 5497b14 to d991804 Compare May 15, 2019 18:53
@renovate renovate bot force-pushed the renovate/google-cloud-translate-4.x branch from d991804 to dbeb19b Compare May 15, 2019 19:29
@renovate
Copy link
Contributor Author

renovate bot commented May 17, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 17, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 17, 2019
@fhinkel
Copy link
Contributor

fhinkel commented May 17, 2019

This update breaks functions/ocr and functions/speech-to-speech. @ace-n please have a look.

@ace-n
Copy link
Contributor

ace-n commented May 17, 2019

Another Node 6 error - so this is blocked on guidance from @stew-r. @fhinkel mind doing one of the following (as I'm severely bandwidth-constrained right now)?

  1. Turn off renovate for functions/
  2. Sync with @stew-r to see if we can move that Node 6 sample deprecation up?

@stew-r
Copy link
Contributor

stew-r commented May 21, 2019

AFAICT functions/speech-to-speech is not currently shown in the GCF docs. Ace, can you confirm? If we're not showing/using these samples anywhere today, I think we can just kill them.

For functions/ocr, I'd be in favor of (in order of preference):

  1. for node.js 6, just pin the dependency to version 3.0.0 (or whichever one does not break Node.js 6)
  2. killing the sample (and making necessary changes on our Functions docs pages)

We should only do (2) if (1) is infeasible.

@ace-n
Copy link
Contributor

ace-n commented May 21, 2019

It looks like a solutions sample, which (arguably) shouldn't be in this repo.

@ricalo are we planning on using this in our product docs, or can we move it elsewhere?

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 1, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 1, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Aug 1, 2019

ocr-app should pass once #1279 landed

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 1, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 1, 2019
@fhinkel fhinkel merged commit 40fc84f into master Aug 1, 2019
@fhinkel fhinkel deleted the renovate/google-cloud-translate-4.x branch August 1, 2019 22:09
This was referenced Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants