Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sendgrid (+ Memcached) sample tests #1285

Merged
merged 5 commits into from
May 15, 2019
Merged

Fix Sendgrid (+ Memcached) sample tests #1285

merged 5 commits into from
May 15, 2019

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented May 14, 2019

The sample wasn't actually running in the testing environment - nodejs-repo-tools should fix that. 🙂

Fixes b/132694066

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 14, 2019
@ace-n ace-n requested a review from fhinkel May 14, 2019 20:14
@ace-n ace-n added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@ace-n ace-n merged commit f700a24 into master May 15, 2019
@ace-n ace-n deleted the fix-sendgrid branch May 15, 2019 19:27
@ace-n ace-n changed the title Use nodejs-repo-tools for testing Sendgrid sample Fix Sendgrid (+ Memcached) sample tests May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants