Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IoT samples to Node 8 #1341

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Update IoT samples to Node 8 #1341

merged 2 commits into from
Jun 5, 2019

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Jun 5, 2019

No description provided.

@ace-n ace-n requested review from fhinkel and hongalex June 5, 2019 18:55
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 5, 2019
hongalex
hongalex approved these changes Jun 5, 2019
View reviewed changes
Copy link
Contributor

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

These changes are really helpful! We've been meaning to switch to an async/await paradigm for managing getClient for a while, so this is great.

iot/manager/system-test/manager.test.js Outdated Show resolved Hide resolved
@ace-n ace-n merged commit 06b4a53 into master Jun 5, 2019
@ace-n ace-n deleted the iot-node8 branch June 5, 2019 20:20
This was referenced May 13, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 13, 2022
Open
This was referenced May 13, 2022
Open
Open
Open
@leejh3224 leejh3224 mentioned this pull request May 13, 2022
Open
This was referenced May 13, 2022
Open
Open
Open
@leejh3224 leejh3224 mentioned this pull request May 13, 2022
Open
@ninadhatkar ninadhatkar mentioned this pull request May 13, 2022
Open
@leejh3224 leejh3224 mentioned this pull request May 14, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 14, 2022
Open
@ninadhatkar ninadhatkar mentioned this pull request May 14, 2022
Open
This was referenced May 14, 2022
Open
Open
@ninadhatkar ninadhatkar mentioned this pull request May 14, 2022
Open
This was referenced May 14, 2022
Open
Open
@leejh3224 leejh3224 mentioned this pull request May 14, 2022
Open
@ninadhatkar ninadhatkar mentioned this pull request May 14, 2022
Open
@leejh3224 leejh3224 mentioned this pull request May 14, 2022
Open
@ninadhatkar ninadhatkar mentioned this pull request May 14, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 14, 2022
Open
@leejh3224 leejh3224 mentioned this pull request May 14, 2022
Open
This was referenced Jun 20, 2023
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@hongalex hongalex hongalex approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ace-n @fhinkel @hongalex @googlebot