Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native Buffer.from() #1440

Merged
merged 1 commit into from
Aug 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion appengine/endpoints/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

const express = require('express');
const bodyParser = require('body-parser');
const {Buffer} = require('safe-buffer');

const app = express();
app.use(bodyParser.json());
Expand Down
3 changes: 1 addition & 2 deletions appengine/endpoints/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
},
"dependencies": {
"body-parser": "^1.18.3",
"express": "^4.16.4",
"safe-buffer": "^5.1.2"
"express": "^4.16.4"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "^3.3.0",
Expand Down
1 change: 0 additions & 1 deletion appengine/endpoints/test/app.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

'use strict';

const {Buffer} = require('safe-buffer');
const express = require('express');
const path = require('path');
const proxyquire = require('proxyquire').noCallThru();
Expand Down
1 change: 0 additions & 1 deletion appengine/pubsub/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const express = require('express');
const bodyParser = require('body-parser');
const {OAuth2Client} = require('google-auth-library');
const path = require('path');
const {Buffer} = require('safe-buffer');
const process = require('process'); // Required for mocking environment variables

// By default, the client will authenticate using the service account file
Expand Down
3 changes: 1 addition & 2 deletions appengine/pubsub/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@
"body-parser": "^1.18.3",
"express": "^4.16.3",
"google-auth-library": "^5.0.0",
"pug": "^2.0.1",
"safe-buffer": "^5.1.2"
"pug": "^2.0.1"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "^3.3.0",
Expand Down
1 change: 0 additions & 1 deletion endpoints/getting-started/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
// [START setup]
const express = require('express');
const bodyParser = require('body-parser');
const {Buffer} = require('safe-buffer');

const app = express();

Expand Down
3 changes: 1 addition & 2 deletions endpoints/getting-started/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
},
"dependencies": {
"body-parser": "^1.18.3",
"express": "^4.16.4",
"safe-buffer": "^5.1.2"
"express": "^4.16.4"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "^3.3.0",
Expand Down
1 change: 0 additions & 1 deletion endpoints/getting-started/test/app.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

'use strict';

const {Buffer} = require('safe-buffer');
const express = require('express');
const path = require('path');
const proxyquire = require('proxyquire').noPreserveCache();
Expand Down
2 changes: 0 additions & 2 deletions functions/helloworld/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@

'use strict';

const {Buffer} = require('safe-buffer');

// [START functions_helloworld_http]
const escapeHtml = require('escape-html');

Expand Down
3 changes: 1 addition & 2 deletions functions/helloworld/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
"dependencies": {
"@google-cloud/debug-agent": "^4.0.0",
"escape-html": "^1.0.3",
"pug": "^2.0.3",
"safe-buffer": "^5.1.2"
"pug": "^2.0.3"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "^3.3.0",
Expand Down
1 change: 0 additions & 1 deletion functions/helloworld/test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
* limitations under the License.
*/

const {Buffer} = require('safe-buffer');
const path = require('path');
const assert = require('assert');
const tools = require('@google-cloud/nodejs-repo-tools');
Expand Down
3 changes: 1 addition & 2 deletions functions/http/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@
"dependencies": {
"@google-cloud/storage": "^3.0.0",
"busboy": "^0.3.0",
"escape-html": "^1.0.3",
"safe-buffer": "^5.1.2"
"escape-html": "^1.0.3"
},
"cloud-repo-tools": {
"requiresKeyFile": true,
Expand Down
1 change: 0 additions & 1 deletion functions/http/test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

'use strict';

const {Buffer} = require('safe-buffer');
const proxyquire = require('proxyquire').noCallThru();
const sinon = require('sinon');
const assert = require('assert');
Expand Down
1 change: 0 additions & 1 deletion functions/ocr/app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ const vision = new Vision.ImageAnnotatorClient();
const {Translate} = require('@google-cloud/translate');
const translate = new Translate();

const {Buffer} = require('safe-buffer');
// [END functions_ocr_setup]

// [START functions_ocr_publish]
Expand Down
3 changes: 1 addition & 2 deletions functions/ocr/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
"@google-cloud/storage": "^3.0.0",
"@google-cloud/translate": "^4.0.0",
"@google-cloud/vision": "^1.0.0",
"nconf": "^0.10.0",
"safe-buffer": "^5.1.2"
"nconf": "^0.10.0"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "^3.3.0",
Expand Down
1 change: 0 additions & 1 deletion functions/ocr/app/test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
'use strict';

const assert = require('assert');
const {Buffer} = require('safe-buffer');

const {Storage} = require('@google-cloud/storage');
const storage = new Storage();
Expand Down
2 changes: 0 additions & 2 deletions functions/pubsub/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ const {PubSub} = require('@google-cloud/pubsub');
const pubsub = new PubSub();
// [END functions_pubsub_setup]

const {Buffer} = require('safe-buffer');

// [START functions_pubsub_publish]
/**
* Publishes a message to a Cloud Pub/Sub Topic.
Expand Down
3 changes: 1 addition & 2 deletions functions/pubsub/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
"test": "mocha test/*.test.js --timeout=20000"
},
"dependencies": {
"@google-cloud/pubsub": "^0.28.1",
"safe-buffer": "^5.2.0"
"@google-cloud/pubsub": "^0.28.1"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "^3.3.0",
Expand Down
1 change: 0 additions & 1 deletion functions/pubsub/test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

const assert = require('assert');
const tools = require('@google-cloud/nodejs-repo-tools');
const {Buffer} = require('safe-buffer');
const path = require('path');

const execPromise = require('child-process-promise').exec;
Expand Down
1 change: 0 additions & 1 deletion functions/scheduleinstance/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

// [START functions_start_instance_pubsub]
// [START functions_stop_instance_pubsub]
const {Buffer} = require('safe-buffer');
const Compute = require('@google-cloud/compute');
const compute = new Compute();
// [END functions_stop_instance_pubsub]
Expand Down
3 changes: 1 addition & 2 deletions functions/scheduleinstance/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"sinon": "^7.0.0"
},
"dependencies": {
"@google-cloud/compute": "^1.0.0",
"safe-buffer": "^5.1.2"
"@google-cloud/compute": "^1.0.0"
}
}
1 change: 0 additions & 1 deletion functions/scheduleinstance/test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@

'use strict';

const {Buffer} = require('safe-buffer');
const proxyquire = require('proxyquire').noCallThru();
const sinon = require('sinon');
const assert = require('assert');
Expand Down
1 change: 0 additions & 1 deletion functions/sendgrid/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
'use strict';

// [START functions_sendgrid_setup]
const {Buffer} = require('safe-buffer');
const sendgrid = require('sendgrid');
const config = require('./config.json');
const uuid = require('uuid');
Expand Down
1 change: 0 additions & 1 deletion functions/sendgrid/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"dependencies": {
"@google-cloud/bigquery": "^4.0.0",
"@google-cloud/storage": "^3.0.0",
"safe-buffer": "^5.1.2",
"sendgrid": "^5.2.3",
"uuid": "^3.3.2"
},
Expand Down
3 changes: 1 addition & 2 deletions functions/tips/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
"test": "mocha test/*.test.js --timeout=60000 --exit"
},
"dependencies": {
"@google-cloud/pubsub": "^0.28.0",
"safe-buffer": "^5.1.2"
"@google-cloud/pubsub": "^0.28.0"
},
"devDependencies": {
"@google-cloud/nodejs-repo-tools": "^3.3.0",
Expand Down
1 change: 0 additions & 1 deletion jobs/v3/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
},
"dependencies": {
"googleapis": "^42.0.0",
"safe-buffer": "^5.1.2",
"uuid": "^3.3.2",
"yargs": "^13.2.2"
},
Expand Down