Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint: Node 8+ WARNINGs --> ERRORs #1489

Merged
merged 40 commits into from
Sep 25, 2019
Merged

ESLint: Node 8+ WARNINGs --> ERRORs #1489

merged 40 commits into from
Sep 25, 2019

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Sep 20, 2019

I tried to break this up piece-wise by commit - so if a sample you own is affected, feel free to review only the relevant commit(s).

ace-n added 25 commits September 20, 2019 13:21
Automated lint fixes
bdbf403
Lint: switch WARNINGs to ERRORs
78705d9
Fix lint: cloudsql
6ca6e75
Fix lint: datacatalog
0986398
Fix lint: endpoints
a0ee631
Fix lint: cloud run
0ffad40
Fix lint: storage transfer
83f3d5f
Fix lint: healthcare
666435a
Fix lint: functions/composer-storage-trigger
65df9c2
Fix lint: functions/firebase
9566280
Fix lint: functions/sendgrid
4dbadcf
Fix lint: functions/spanner
7c48f36
Fix lint: functions/env_vars
c39574e
Fix lint: functions/http
8a8fd3e
Fix lint: functions/imagemagick
cfc5a50
Fix lint: functions/log
d1759ca
Fix lint: functions/memorystore/redis
d1bd17c
Fix lint: functions/node8
389bc8b
Fix lint: functions/scheduleinstance
f6ba8ae
Fix lint: functions/slack
8dfec0e
Fix lint: functions/sql
5989c17
Fix lint: functions/tips
ccf9358
Fix lint: functions/tokenservice/functions
4e2dc3e
Fix lint: run/logging-manual
dbaf523
Fix lint: datacatalog
2196212
@ace-n ace-n requested a review from fhinkel September 20, 2019 20:23
djmailhot
djmailhot reviewed Sep 24, 2019
View reviewed changes
Copy link
Contributor

@djmailhot djmailhot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files reviewed:

  • functions/scheduleinstance/*

The updated code does not behave as expected. Please take a look at the in-line comment

functions/scheduleinstance/index.js Show resolved Hide resolved
jsimonweb
jsimonweb approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@jsimonweb jsimonweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functions/spanner changes LGTM

gguuss
gguuss approved these changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for IoT.

djmailhot
djmailhot approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@djmailhot djmailhot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functions/scheduleinstance/*

@ace-n ace-n merged commit ebcc861 into master Sep 25, 2019
@ace-n ace-n deleted the linter-errors branch September 25, 2019 23:05
@ace-n ace-n mentioned this pull request Sep 25, 2019
Closed
@aqualen aqualen mentioned this pull request Jul 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jul 31, 2022
Open
@aqualen aqualen mentioned this pull request Jul 31, 2022
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Jul 31, 2022
Open
@aqualen aqualen mentioned this pull request Jul 31, 2022
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Jul 31, 2022
Open
This was referenced Jul 31, 2022
Open
Open
This was referenced Aug 1, 2022
Open
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Aug 1, 2022
Open
@aqualen aqualen mentioned this pull request Aug 1, 2022
Open
@leejh3224 leejh3224 mentioned this pull request Aug 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grant grant grant approved these changes

@leahecole leahecole leahecole left review comments

@fhinkel fhinkel fhinkel approved these changes

@djmailhot djmailhot djmailhot approved these changes

@jsimonweb jsimonweb jsimonweb approved these changes

@gguuss gguuss gguuss approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ace-n @fhinkel @djmailhot @grant @jsimonweb @gguuss @leahecole @kurtisvg @googlebot