Storage ACL samples. #172

jmdobry · 2016-08-18T05:04:45Z

jmdobry · 2016-08-18T05:04:58Z

@ace-n Ready for review

ace-n · 2016-08-18T05:08:03Z

storage/README.md

+__Usage:__ `node acl --help`
+
+```
+Commands:


Wishlist/Pipe dream: auto-generate these.

You mean auto-generate all of README.md? The usage information was generated, I just ran node acl --help and pasted the output into README.md. I used to have to write all that by hand, now most of README.md is generated.

Generated in the "I don't have to even paste things in, I just run a script" sense.

I think there's negligible work to be saved by scripting the copy paste. I mean, it could be scripted, but we'd need to devise a manifest.json file or something that could give the script meta information about the samples in the directory. Maybe it's not such a bad idea...

codecov-io · 2016-08-18T05:50:04Z

Current coverage is 87.09% (diff: 97.87%)

Merging #172 into master will increase coverage by 0.20%

@@             master       #172   diff @@
==========================================
  Files            56         57     +1   
  Lines          2486       2533    +47   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2160       2206    +46   
- Misses          326        327     +1   
  Partials          0          0

Powered by Codecov. Last update e8e3e9d...dd1b552

ace-n · 2016-08-18T05:51:25Z

storage/test/acl.test.js

+
+      sample.program.deleteAccessControl(options, callback);
+
+      assert(callback.calledOnce, 'callback called once');


What are the tradeoffs of this pattern vs. defining a callback function and putting the tests in the there? (And which should I be using in my tests?)

I would say the two main benefits are:

Use of sinon.stub as the callback allows for additional assertions about the code execution (it gathers more info about how the callback is used)

The test function now actually looks synchronous in addition to being synchronous.

ace-n · 2016-08-18T05:55:31Z

LGTM other than a few minor nits.

🤖 I have created a release \*beep\* \*boop\* --- ### [3.2.4](https://www.github.com/googleapis/nodejs-service-directory/compare/v3.2.3...v3.2.4) (2021-08-17) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#172](https://www.github.com/googleapis/nodejs-service-directory/issues/172)) ([f6a501e](https://www.github.com/googleapis/nodejs-service-directory/commit/f6a501ea9d4ff30a6df9fbfc74db80c4e402a932)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [1.9.1](https://www.github.com/googleapis/nodejs-ai-platform/compare/v1.9.0...v1.9.1) (2021-07-21) ### Bug Fixes * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#172](https://www.github.com/googleapis/nodejs-ai-platform/issues/172)) ([d22eceb](https://www.github.com/googleapis/nodejs-ai-platform/commit/d22ecebc4693b63516a69753c19fa7a7a400464f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [1.9.1](https://www.github.com/googleapis/nodejs-ai-platform/compare/v1.9.0...v1.9.1) (2021-07-21) ### Bug Fixes * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#172](https://www.github.com/googleapis/nodejs-ai-platform/issues/172)) ([d22eceb](https://www.github.com/googleapis/nodejs-ai-platform/commit/d22ecebc4693b63516a69753c19fa7a7a400464f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Storage ACL samples.

4274735

jmdobry assigned ace-n Aug 18, 2016

ace-n reviewed Aug 18, 2016
View reviewed changes

Added links to relevant gcloud-node methods.

dd1b552

ace-n reviewed Aug 18, 2016
View reviewed changes

jmdobry merged commit e4958b0 into master Aug 18, 2016

jmdobry deleted the permissions branch August 18, 2016 07:06

kweinmeister pushed a commit that referenced this pull request Nov 10, 2022

chore(deps): lock file maintenance (#172)

0dd9f74

kweinmeister mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-error-reporting #2821

Merged

ace-n pushed a commit that referenced this pull request Nov 11, 2022

chore(deps): lock file maintenance (#172)

7494bea

ace-n pushed a commit that referenced this pull request Nov 11, 2022

chore(deps): lock file maintenance (#172)

5295718

telpirion mentioned this pull request Nov 16, 2022

chore(vision): migrate code from googleapis/nodejs-vision #2858

Merged

telpirion pushed a commit that referenced this pull request Nov 16, 2022

Udpate Beta Vision samples to use beta tags (#172)

d74b2c8

jsimonweb pushed a commit to jsimonweb/nodejs-docs-samples that referenced this pull request Dec 12, 2022

fix: update dependencies to latest versions (GoogleCloudPlatform#172)

09252f3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Storage ACL samples. #172

Storage ACL samples. #172

jmdobry commented Aug 18, 2016

jmdobry commented Aug 18, 2016

ace-n Aug 18, 2016

jmdobry Aug 18, 2016 •

edited

Loading

ace-n Aug 18, 2016

jmdobry Aug 18, 2016

codecov-io commented Aug 18, 2016

ace-n Aug 18, 2016

jmdobry Aug 18, 2016

ace-n commented Aug 18, 2016


		sample.program.deleteAccessControl(options, callback);

		assert(callback.calledOnce, 'callback called once');

Storage ACL samples. #172

Storage ACL samples. #172

Conversation

jmdobry commented Aug 18, 2016

jmdobry commented Aug 18, 2016

ace-n Aug 18, 2016

Choose a reason for hiding this comment

jmdobry Aug 18, 2016 • edited Loading

Choose a reason for hiding this comment

ace-n Aug 18, 2016

Choose a reason for hiding this comment

jmdobry Aug 18, 2016

Choose a reason for hiding this comment

codecov-io commented Aug 18, 2016

Current coverage is 87.09% (diff: 97.87%)

ace-n Aug 18, 2016

Choose a reason for hiding this comment

jmdobry Aug 18, 2016

Choose a reason for hiding this comment

ace-n commented Aug 18, 2016

jmdobry Aug 18, 2016 •

edited

Loading