Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change for...of to for...in #1744

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Change for...of to for...in #1744

merged 1 commit into from
Apr 24, 2020

Conversation

Baystef
Copy link
Contributor

@Baystef Baystef commented Apr 24, 2020

At the busboy.on('finish') event, looping the uploads object with for...of will throw a "uploads is not iterable" error because for...of does not work on objects. The correct for-loop to use here will be for...in

At the busboy.on('finish') event, looping the uploads object with for...of will throw a "uploads is not iterable" error because for...of does not work on objects. The correct for-loop to use here will be for...in
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 24, 2020
@Baystef
Copy link
Contributor Author

Baystef commented Apr 24, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 24, 2020
@ace-n ace-n added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Baystef thanks for the fix! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants