Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor composer test #1779

Merged
merged 8 commits into from
May 13, 2020
Merged

chore: refactor composer test #1779

merged 8 commits into from
May 13, 2020

Conversation

Strykrol
Copy link
Contributor

@Strykrol Strykrol commented May 1, 2020

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2020
@ace-n ace-n changed the title test tracker: wrap tests in region tags [composer] Add region tags to tests May 1, 2020
@fhinkel fhinkel changed the title [composer] Add region tags to tests chore: refactor composer test May 4, 2020
@fhinkel fhinkel requested a review from ace-n May 4, 2020 12:01
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 8, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 8, 2020
ace-n
ace-n approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once tests pass. Thanks for doing this! 🙂

@ace-n ace-n added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 12, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 12, 2020
@fhinkel fhinkel merged commit e48a5cf into GoogleCloudPlatform:master May 13, 2020
@Matthelonianxl Matthelonianxl mentioned this pull request Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofisl sofisl sofisl approved these changes

@ace-n ace-n ace-n approved these changes

@leahecole leahecole Awaiting requested review from leahecole

Assignees

@ace-n ace-n

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Strykrol @ace-n @sofisl @fhinkel @googlebot @kokoro-team