feat: Update .kokoro/build.sh to run proxy when testing Cloud SQL samples #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Basic idea LGTM. @shubha-rajan can you get the build passing, and ask @fhinkel to take another look once that's done? (I'll probably be OOO later this week due to an internal COVID-19 project.) |
shubha-rajan
force-pushed
the
build-proxy
branch
7 times, most recently
from
d3a95d4
to
7666b84
Compare
shubha-rajan
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
shubha-rajan
added
kokoro:run
shubha-rajan
force-pushed
the
build-proxy
branch
2 times, most recently
from
27b4e66
to
bcb9278
Compare
|
@fhinkel this is ready for review! |
fhinkel
approved these changes
May 7, 2020
fhinkel
added
kokoro:run
kokoro-team
removed
the
kokoro:run
This was referenced May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For integration testing of connectivity samples. This PR is blocking #1745 from being merged.