Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move spanner out of functions dir + update owners #1826

Merged
merged 3 commits into from
May 21, 2020
Merged

Move spanner out of functions dir + update owners #1826

merged 3 commits into from
May 21, 2020

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented May 20, 2020 •
edited
Loading

Do not merge

  • until @skuruppu LGTMs
  • until cl/312580744 is approved

@ace-n ace-n requested a review from fhinkel May 20, 2020 22:56
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2020
fhinkel
fhinkel approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass.

@ace-n ace-n added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 21, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 21, 2020
@ace-n ace-n merged commit 07b20f5 into master May 21, 2020
@ace-n ace-n deleted the cf-spanner-move branch May 21, 2020 03:11
ace-n pushed a commit that referenced this pull request May 21, 2020
Revert "Move spanner out of functions dir + update owners (#1826)"
d47825b 
This reverts commit 07b20f5.
@ace-n ace-n mentioned this pull request May 21, 2020
Merged
ace-n pushed a commit that referenced this pull request May 21, 2020
Revert "Move spanner out of functions dir + update owners (#1826)" (#…
33dbf6f 
…1828)

This reverts commit 07b20f5.
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuruppu skuruppu skuruppu approved these changes

@fhinkel fhinkel fhinkel approved these changes

@grant grant Awaiting requested review from grant

@jsimonweb jsimonweb Awaiting requested review from jsimonweb

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ace-n @fhinkel @skuruppu @googlebot @kokoro-team