Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update dependency @google-cloud/speech to v4 #1840

Merged
merged 3 commits into from
Jun 7, 2020
Merged

fix(deps): update dependency @google-cloud/speech to v4 #1840

merged 3 commits into from
Jun 7, 2020

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jun 2, 2020 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
@google-cloud/speech dependencies major ^3.0.0 -> ^4.0.0

Release Notes

googleapis/nodejs-speech

v4.0.0

Compare Source

⚠ BREAKING CHANGES
  • The library now supports Node.js v10+. The last version to support Node.js v8 is tagged legacy-8 on NPM.
Features
Bug Fixes

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from ricalo as a code owner June 2, 2020 22:11
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 2, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 2, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 2, 2020
@renovate-bot renovate-bot force-pushed the renovate/google-cloud-speech-4.x branch from 49c99c6 to 8764f8d Compare June 2, 2020 23:38
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 2, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 2, 2020
@fhinkel
Copy link
Contributor

fhinkel commented Jun 4, 2020

@ricalo can you look into the failing test please

@ricalo
Copy link
Member

ricalo commented Jun 4, 2020 •
edited
Loading

It looks like the speech-to-speech sample just needs to bump the Node.js engine to 10. Could you take a look at #1845, @fhinkel?

@renovate-bot renovate-bot force-pushed the renovate/google-cloud-speech-4.x branch from 8764f8d to baaa0c1 Compare June 5, 2020 15:56
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@renovate-bot renovate-bot force-pushed the renovate/google-cloud-speech-4.x branch from baaa0c1 to 0dea2f6 Compare June 5, 2020 16:09
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@renovate-bot renovate-bot force-pushed the renovate/google-cloud-speech-4.x branch from 0dea2f6 to aae137f Compare June 5, 2020 16:29
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@renovate-bot renovate-bot force-pushed the renovate/google-cloud-speech-4.x branch from aae137f to 2b2fd4e Compare June 5, 2020 16:53
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@renovate-bot renovate-bot force-pushed the renovate/google-cloud-speech-4.x branch from 2b2fd4e to 61a40c1 Compare June 5, 2020 18:49
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@renovate-bot renovate-bot force-pushed the renovate/google-cloud-speech-4.x branch from 7e8a12f to c16cb56 Compare June 5, 2020 20:53
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 5, 2020
@forking-renovate
Copy link

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@forking-renovate
Copy link

Autoclosing Skipped

This PR has been flagged for autoclosing, however it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 7, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 7, 2020
ricalo
ricalo approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@ricalo ricalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval as maintainer of the speech-to-speech sample.

@fhinkel fhinkel merged commit 36c1991 into GoogleCloudPlatform:master Jun 7, 2020
@renovate-bot renovate-bot deleted the renovate/google-cloud-speech-4.x branch June 7, 2020 21:31
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricalo ricalo ricalo approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees

@ricalo ricalo

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@renovate-bot @fhinkel @ricalo @googlebot @kokoro-team