Add remaining Translate samples. #197

jmdobry · 2016-08-30T21:38:23Z

No description provided.

ace-n · 2016-08-31T00:35:21Z

translate/test/translate.test.js

@@ -103,7 +104,7 @@ describe('translate:translate', function () {
      var error = new Error('error');
      var sample = getSample();
      var callback = sinon.stub();
-      sample.mocks.translate.getLanguages = sinon.stub().callsArgWith(0, error);
+      sample.mocks.translate.getLanguages.yields(error);


Nit: this should be in a separate PR - not that I care. 😛

ace-n · 2016-08-31T00:49:22Z

Left a few comments. Fix those and it should be LGTM.

jmdobry · 2016-08-31T16:28:28Z

Addressed comments.

ace-n · 2016-08-31T17:20:52Z

translate/system-test/translate.test.js

+    });
+
+    it('should list languages with a different target', function (done) {
+      program.listLanguages('es', apiKey, function (err, languages) {
        assert.ifError(err);
        assert(Array.isArray(languages));
        assert(languages.length > 0);


Can/should we assert that the target is recognized here? e.g.

assert.equal(languages.contains("Espanol"), true);

ace-n · 2016-08-31T17:44:19Z

Just a few minor nits - fix those and I'll LGTM.

jmdobry · 2016-09-01T16:35:47Z

Addressed comments.

codecov-io · 2016-09-01T17:38:28Z

Current coverage is 89.17% (diff: 100%)

Merging #197 into master will increase coverage by 0.04%

@@             master       #197   diff @@
==========================================
  Files            57         57          
  Lines          2382       2392    +10   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2123       2133    +10   
  Misses          259        259          
  Partials          0          0

Powered by Codecov. Last update 2f9b34f...eff41c3

ace-n · 2016-09-01T17:49:03Z

translate/test/translate.test.js

+        sinon.stub(program, 'detectLanguage');
+        program.main(['detect', text, '-k', apiKey]);
+        assert.equal(program.detectLanguage.calledOnce, true);
+        assert.deepEqual(program.detectLanguage.firstCall.args.slice(0, -1), [[text]]);


Should this be setting an environment variable? If so, can we test that?

ace-n · 2016-09-01T17:59:03Z

LGTM, other than a few nits.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* updated CHANGELOG.md * updated package.json * updated samples/package.json

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* updated CHANGELOG.md * updated package.json * updated samples/package.json

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* updated CHANGELOG.md * updated package.json * updated samples/package.json

…form#197) This is a port of GoogleCloudPlatform/cloud-sql-proxy#1514.

* Fixed issues in some cases when user setting up environment. * fix: use bash trap Co-authored-by: Alexander Fenster <github@fenster.name>

jmdobry assigned ace-n Aug 30, 2016

ace-n reviewed Aug 31, 2016
View reviewed changes

jmdobry force-pushed the translate branch from cf836ca to 5df96a4 Compare August 31, 2016 16:28

jmdobry force-pushed the translate branch from 5df96a4 to 89aa0d7 Compare August 31, 2016 16:29

ace-n reviewed Aug 31, 2016
View reviewed changes

jmdobry force-pushed the translate branch 3 times, most recently from f840a08 to eff41c3 Compare September 1, 2016 16:34

ace-n reviewed Sep 1, 2016
View reviewed changes

jmdobry force-pushed the translate branch from eff41c3 to 1cce80a Compare September 1, 2016 20:41

Add remaining Translate samples.

1cce80a

ace-n mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-document-ai #2842

Closed

ace-n pushed a commit that referenced this pull request Nov 11, 2022

chore: release 2.8.0 (#197)

328d803

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ace-n pushed a commit that referenced this pull request Nov 11, 2022

chore: release 1.2.0 (#197)

455993a

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n pushed a commit that referenced this pull request Nov 11, 2022

chore: release 2.8.0 (#197)

0ba68c4

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ace-n mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-document-ai #2843

Merged

ace-n pushed a commit that referenced this pull request Nov 12, 2022

chore: release 2.8.0 (#197)

9123754

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ace-n pushed a commit that referenced this pull request Nov 14, 2022

chore: release 1.4.3 (#197)

82d291a

ace-n mentioned this pull request Nov 14, 2022

migrate code from googleapis/nodejs-scheduler #2848

Closed

ace-n pushed a commit that referenced this pull request Nov 14, 2022

chore: release 1.4.3 (#197)

83d00f5

ace-n mentioned this pull request Nov 14, 2022

migrate code from googleapis/nodejs-scheduler #2849

Merged

ace-n pushed a commit that referenced this pull request Nov 14, 2022

chore: release 1.2.0 (#197)

082c009

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n pushed a commit that referenced this pull request Nov 14, 2022

chore: release 2.8.0 (#197)

94adf3b

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ace-n pushed a commit that referenced this pull request Nov 14, 2022

chore: release 1.4.3 (#197)

8736416

ace-n pushed a commit that referenced this pull request Nov 15, 2022

chore: release 1.4.3 (#197)

01688ec

ace-n pushed a commit that referenced this pull request Nov 15, 2022

chore: release 1.2.0 (#197)

e576033

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n pushed a commit that referenced this pull request Nov 15, 2022

chore: release 1.2.0 (#197)

62cf4ed

* updated CHANGELOG.md * updated package.json * updated samples/package.json

telpirion mentioned this pull request Nov 16, 2022

chore(vision): migrate code from googleapis/nodejs-vision #2858

Merged

telpirion pushed a commit that referenced this pull request Nov 16, 2022

docs: Vision AutoML samples (#197)

7b4b7b8

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore: release 1.2.0 (#197)

a7af828

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore: release 1.2.0 (#197)

7acaa01

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n pushed a commit that referenced this pull request Nov 17, 2022

Add remaining Translate samples. (#197)

426a8e7

ace-n mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-translate #2862

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

Add remaining Translate samples. (#197)

6bb402a

ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022

chore: release 1.2.0 (#197)

a80a2c3

* updated CHANGELOG.md * updated package.json * updated samples/package.json

ace-n pushed a commit that referenced this pull request Nov 17, 2022

Add remaining Translate samples. (#197)

34e5902

ace-n pushed a commit that referenced this pull request Nov 17, 2022

Add remaining Translate samples. (#197)

e7416cf

ace-n pushed a commit that referenced this pull request Nov 17, 2022

Add remaining Translate samples. (#197)

b488ea8

jsimonweb pushed a commit to jsimonweb/nodejs-docs-samples that referenced this pull request Dec 12, 2022

feat: configure the proxy with environment variables (GoogleCloudPlat…

cfcf17d

…form#197) This is a port of GoogleCloudPlatform/cloud-sql-proxy#1514.

kweinmeister pushed a commit that referenced this pull request Jan 11, 2023

samples: properly catch errors (#197)

82ecff4

* Fixed issues in some cases when user setting up environment. * fix: use bash trap Co-authored-by: Alexander Fenster <github@fenster.name>

kweinmeister mentioned this pull request Jan 11, 2023

migrate code from googleapis/nodejs-retail #2975

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add remaining Translate samples. #197

Add remaining Translate samples. #197

jmdobry commented Aug 30, 2016

ace-n Aug 31, 2016

ace-n commented Aug 31, 2016

jmdobry commented Aug 31, 2016

ace-n Aug 31, 2016

ace-n commented Aug 31, 2016

jmdobry commented Sep 1, 2016

codecov-io commented Sep 1, 2016

ace-n Sep 1, 2016

jmdobry Sep 1, 2016

ace-n commented Sep 1, 2016

Add remaining Translate samples. #197

Add remaining Translate samples. #197

Conversation

jmdobry commented Aug 30, 2016

ace-n Aug 31, 2016

Choose a reason for hiding this comment

ace-n commented Aug 31, 2016

jmdobry commented Aug 31, 2016

ace-n Aug 31, 2016

Choose a reason for hiding this comment

ace-n commented Aug 31, 2016

jmdobry commented Sep 1, 2016

codecov-io commented Sep 1, 2016

Current coverage is 89.17% (diff: 100%)

ace-n Sep 1, 2016

Choose a reason for hiding this comment

jmdobry Sep 1, 2016

Choose a reason for hiding this comment

ace-n commented Sep 1, 2016