Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove supertest from deps #1995

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Conversation

grant
Copy link
Contributor

@grant grant commented Oct 6, 2020

Removes supertest from a sample's deps (functions/helloworld/package.json). Should be dev deps.

Related: #1983

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant requested a review from ace-n October 6, 2020 20:05
@grant grant self-assigned this Oct 6, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 6, 2020
@grant grant merged commit 33b65bb into master Oct 6, 2020
@grant grant deleted the grant_functions_supertest_dep branch October 6, 2020 20:32
This was referenced Jan 11, 2022
This was referenced Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants