Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix asserts and related stubs. #206

Merged
merged 2 commits into from
Sep 6, 2016
Merged

Fix asserts and related stubs. #206

merged 2 commits into from
Sep 6, 2016

Conversation

jmdobry
Copy link
Member

@jmdobry jmdobry commented Sep 6, 2016

No description provided.

ace-n
ace-n reviewed Sep 6, 2016
View reviewed changes
bigquery/test/queries.test.js
));
assert.equal(example.mocks.job.getMetadata.calledOnce, true);
assert.deepEqual(example.mocks.job.getMetadata.firstCall.args.slice(0, -1), []);
assert.equal(example.mocks.job.getQueryResults.calledOnce, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check the args of this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ace-n
Copy link
Contributor

ace-n commented Sep 6, 2016

LGTM assuming all (relevant) tests pass on Travis - just a few minor nits.

@jmdobry
Copy link
Member Author

jmdobry commented Sep 6, 2016

The one failing travis test is unrelated. Apparently one of the eslint dependencies committed a const and Node.js 0.12.x throws a strange error when it sees the const.

@jmdobry jmdobry merged commit a4de29a into master Sep 6, 2016
@jmdobry jmdobry deleted the asserts branch September 6, 2016 22:38
This was referenced Mar 11, 2022
Open
Open
NimJay pushed a commit that referenced this pull request Nov 9, 2022
@renovate-bot
chore(deps): update dependency uuid to v8 (#206)
536f566 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [uuid](https://github.com/uuidjs/uuid) | devDependencies | major | [`^7.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/uuid/7.0.3/8.0.0) |

---

### Release Notes

<details>
<summary>uuidjs/uuid</summary>

### [`v8.0.0`](https://github.com/uuidjs/uuid/blob/master/CHANGELOG.md#&#8203;800-httpsgithubcomuuidjsuuidcomparev703v800-2020-04-29)

[Compare Source](https://github.com/uuidjs/uuid/compare/v7.0.3...v8.0.0)

##### ⚠ BREAKING CHANGES

-   For native ECMAScript Module (ESM) usage in Node.js only named exports are exposed, there is no more default export.

    ```diff
    -import uuid from 'uuid';
    -console.log(uuid.v4()); // -> 'cd6c3b08-0adc-4f4b-a6ef-36087a1c9869'
    +import { v4 as uuidv4 } from 'uuid';
    +uuidv4(); // ⇨ '9b1deb4d-3b7d-4bad-9bdd-2b0d7b3dcb6d'
    ```

-   Deep requiring specific algorithms of this library like `require('uuid/v4')`, which has been deprecated in `uuid@7`, is no longer supported.

    Instead use the named exports that this module exports.

    For ECMAScript Modules (ESM):

    ```diff
    -import uuidv4 from 'uuid/v4';
    +import { v4 as uuidv4 } from 'uuid';
    uuidv4();
    ```

    For CommonJS:

    ```diff
    -const uuidv4 = require('uuid/v4');
    +const { v4: uuidv4 } = require('uuid');
    uuidv4();
    ```

##### Features

-   native Node.js ES Modules (wrapper approach) ([#&#8203;423](https://github.com/uuidjs/uuid/issues/423)) ([2d9f590](https://github.com/uuidjs/uuid/commit/2d9f590ad9701d692625c07ed62f0a0f91227991)), closes [#&#8203;245](https://github.com/uuidjs/uuid/issues/245) [#&#8203;419](https://github.com/uuidjs/uuid/issues/419) [#&#8203;342](https://github.com/uuidjs/uuid/issues/342)
-   remove deep requires ([#&#8203;426](https://github.com/uuidjs/uuid/issues/426)) ([daf72b8](https://github.com/uuidjs/uuid/commit/daf72b84ceb20272a81bb5fbddb05dd95922cbba))

##### Bug Fixes

-   add CommonJS syntax example to README quickstart section ([#&#8203;417](https://github.com/uuidjs/uuid/issues/417)) ([e0ec840](https://github.com/uuidjs/uuid/commit/e0ec8402c7ad44b7ef0453036c612f5db513fda0))

##### [7.0.3](https://github.com/uuidjs/uuid/compare/v7.0.2...v7.0.3) (2020-03-31)

##### Bug Fixes

-   make deep require deprecation warning work in browsers ([#&#8203;409](https://github.com/uuidjs/uuid/issues/409)) ([4b71107](https://github.com/uuidjs/uuid/commit/4b71107d8c0d2ef56861ede6403fc9dc35a1e6bf)), closes [#&#8203;408](https://github.com/uuidjs/uuid/issues/408)

##### [7.0.2](https://github.com/uuidjs/uuid/compare/v7.0.1...v7.0.2) (2020-03-04)

##### Bug Fixes

-   make access to msCrypto consistent ([#&#8203;393](https://github.com/uuidjs/uuid/issues/393)) ([8bf2a20](https://github.com/uuidjs/uuid/commit/8bf2a20f3565df743da7215eebdbada9d2df118c))
-   simplify link in deprecation warning ([#&#8203;391](https://github.com/uuidjs/uuid/issues/391)) ([bb2c8e4](https://github.com/uuidjs/uuid/commit/bb2c8e4e9f4c5f9c1eaaf3ea59710c633cd90cb7))
-   update links to match content in readme ([#&#8203;386](https://github.com/uuidjs/uuid/issues/386)) ([44f2f86](https://github.com/uuidjs/uuid/commit/44f2f86e9d2bbf14ee5f0f00f72a3db1292666d4))

##### [7.0.1](https://github.com/uuidjs/uuid/compare/v7.0.0...v7.0.1) (2020-02-25)

##### Bug Fixes

-   clean up esm builds for node and browser ([#&#8203;383](https://github.com/uuidjs/uuid/issues/383)) ([59e6a49](https://github.com/uuidjs/uuid/commit/59e6a49e7ce7b3e8fb0f3ee52b9daae72af467dc))
-   provide browser versions independent from module system ([#&#8203;380](https://github.com/uuidjs/uuid/issues/380)) ([4344a22](https://github.com/uuidjs/uuid/commit/4344a22e7aed33be8627eeaaf05360f256a21753)), closes [#&#8203;378](https://github.com/uuidjs/uuid/issues/378)

</details>

---

### Renovate configuration

:date: **Schedule**: "after 9am and before 3pm" (UTC).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-containeranalysis).
@NimJay NimJay mentioned this pull request Nov 9, 2022
Closed
pattishin pushed a commit that referenced this pull request Nov 9, 2022
@sofisl @gcf-owl-bot
fix(build): migrate to using main branch (#206)
52c01d3 
* fix(build): migrate to using main branch

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
pattishin pushed a commit that referenced this pull request Nov 9, 2022
@release-please
chore: release 2.3.8 (#207)
c49e829 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.8](https://www.github.com/googleapis/nodejs-game-servers/compare/v2.3.7...v2.3.8) (2021-08-17)


### Bug Fixes

* **build:** migrate to using main branch ([#206](https://www.github.com/googleapis/nodejs-game-servers/issues/206)) ([04998bf](https://www.github.com/googleapis/nodejs-game-servers/commit/04998bf4f24613792beb12fff9d1a14da795b74b))
* **deps:** google-gax v2.24.1 ([#208](https://www.github.com/googleapis/nodejs-game-servers/issues/208)) ([8462da4](https://www.github.com/googleapis/nodejs-game-servers/commit/8462da415e3df130356f70e34f97698628f48b2b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@pattishin pattishin mentioned this pull request Nov 9, 2022
Closed
pattishin pushed a commit that referenced this pull request Nov 9, 2022
@release-please
chore: release 2.3.8 (#207)
8af821e 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.8](https://www.github.com/googleapis/nodejs-game-servers/compare/v2.3.7...v2.3.8) (2021-08-17)


### Bug Fixes

* **build:** migrate to using main branch ([#206](https://www.github.com/googleapis/nodejs-game-servers/issues/206)) ([04998bf](https://www.github.com/googleapis/nodejs-game-servers/commit/04998bf4f24613792beb12fff9d1a14da795b74b))
* **deps:** google-gax v2.24.1 ([#208](https://www.github.com/googleapis/nodejs-game-servers/issues/208)) ([8462da4](https://www.github.com/googleapis/nodejs-game-servers/commit/8462da415e3df130356f70e34f97698628f48b2b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
pattishin pushed a commit that referenced this pull request Nov 9, 2022
@release-please
chore: release 2.3.8 (#207)
9629897 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.8](https://www.github.com/googleapis/nodejs-game-servers/compare/v2.3.7...v2.3.8) (2021-08-17)


### Bug Fixes

* **build:** migrate to using main branch ([#206](https://www.github.com/googleapis/nodejs-game-servers/issues/206)) ([04998bf](https://www.github.com/googleapis/nodejs-game-servers/commit/04998bf4f24613792beb12fff9d1a14da795b74b))
* **deps:** google-gax v2.24.1 ([#208](https://www.github.com/googleapis/nodejs-game-servers/issues/208)) ([8462da4](https://www.github.com/googleapis/nodejs-game-servers/commit/8462da415e3df130356f70e34f97698628f48b2b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Nov 11, 2022
Closed
Merged
Closed
NimJay pushed a commit that referenced this pull request Nov 11, 2022
@release-please @NimJay
chore: release 2.3.8 (#207)
89ecb50 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.8](https://www.github.com/googleapis/nodejs-game-servers/compare/v2.3.7...v2.3.8) (2021-08-17)


### Bug Fixes

* **build:** migrate to using main branch ([#206](https://www.github.com/googleapis/nodejs-game-servers/issues/206)) ([04998bf](https://www.github.com/googleapis/nodejs-game-servers/commit/04998bf4f24613792beb12fff9d1a14da795b74b))
* **deps:** google-gax v2.24.1 ([#208](https://www.github.com/googleapis/nodejs-game-servers/issues/208)) ([8462da4](https://www.github.com/googleapis/nodejs-game-servers/commit/8462da415e3df130356f70e34f97698628f48b2b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation @JustinBeckwith
chore: release 1.2.2 (#206)
cef387f 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
@ace-n ace-n mentioned this pull request Nov 11, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation @JustinBeckwith
chore: release 1.2.2 (#206)
1d89a12 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
ace-n pushed a commit that referenced this pull request Nov 14, 2022
@yoshi-automation
chore: release 1.2.2 (#206)
6709e61 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
ace-n pushed a commit that referenced this pull request Nov 15, 2022
@yoshi-automation
chore: release 1.2.2 (#206)
62ae71b 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
ace-n pushed a commit that referenced this pull request Nov 15, 2022
@yoshi-automation
chore: release 1.2.2 (#206)
f5fbfda 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
grayside pushed a commit that referenced this pull request Nov 16, 2022
@yoshi-automation @JustinBeckwith
chore: release 1.1.1 (#206)
27a253f 
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
@grayside grayside mentioned this pull request Nov 16, 2022
Closed
@grayside grayside mentioned this pull request Nov 16, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@yoshi-automation
chore: release 1.2.2 (#206)
45c9d7c 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@yoshi-automation
chore: release 1.2.2 (#206)
71c71b9 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@yoshi-automation
chore: release 1.1.1 (#206)
0ae618e 
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
grayside pushed a commit that referenced this pull request Nov 17, 2022
@yoshi-automation @grayside
chore: release 1.1.1 (#206)
908300d 
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
@yoshi-automation @ahrarmonsur
chore: release 1.2.2 (#206)
d34bb09 
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
@yoshi-automation @ahrarmonsur
chore: release 1.1.1 (#206)
f399370 
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ace-n ace-n

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmdobry @ace-n