Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate assessed sample as requested by techwriting #3038

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

Shabirmean
Copy link
Member

Description

  • This PR is related to an earlier PR: samples: migrate code from googleapis/nodejs-dlp #3035
  • The earlier PR migrated samples from the nodejs-dlp repository to this mono-samples repository
  • However, one sample and its resources were left behind since it was not referenced anywhere
  • Upon assessing the sample the request from the Eng, DEE, and TW teams is migrate this sample as well and get it referenced.
  • Thus, the resources removed in commits ad775a1 and 2fb1355 of the original migration PR are added back in, in this PR

@Shabirmean Shabirmean requested review from a team as code owners February 17, 2023 15:32
@snippet-bot
Copy link

snippet-bot bot commented Feb 17, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 17, 2023
@Shabirmean Shabirmean merged commit c083c26 into main Feb 17, 2023
@Shabirmean Shabirmean deleted the dlp-migration-assessed branch February 17, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants