Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds tune LLM sample #3273

Merged
merged 23 commits into from
Jun 26, 2023
Merged

feat: adds tune LLM sample #3273

merged 23 commits into from
Jun 26, 2023

Conversation

telpirion
Copy link
Contributor

This PR adds the region tag aiplatform_model_tuning for Node.js.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: aiplatform Issues related to the AI Platform API. labels Jun 14, 2023
@telpirion telpirion marked this pull request as ready for review June 14, 2023 22:56
@telpirion telpirion requested review from a team as code owners June 14, 2023 22:56
@snippet-bot
Copy link

snippet-bot bot commented Jun 14, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@pattishin
Copy link
Contributor

@telpirion nice! do you mind checking on the ai-platform-snippets workflow failure?

@kweinmeister
Copy link
Collaborator

Looks like it might just be missing "sinon" in devDependencies.

@kweinmeister
Copy link
Collaborator

In logs, failing with:

Tune a model
       should prompt-tune an existing model:
     Error: 3 INVALID_ARGUMENT: You do not have permission to act as service_account:

FYI @gericdong

@telpirion
Copy link
Contributor Author

For posterity: the GCP project used for Vertex AI (pointed to by process.env.CAIP_PROJECT_ID) is not the same as the project used by the rest/most of nodejs-docs-samples. When this test attempted to create a new storage bucket for output, it was using invalid ADC (not using the process.env.CAIP_PROJECT_ID service account).

@telpirion telpirion added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 22, 2023
@pattishin
Copy link
Contributor

Checking this out more. Investigating that last test failure around the uCAIP service account 🧐

@gericdong
Copy link
Collaborator

Just removed the public access prevention for the storage bucket to see if this is the cause of the permission issue.

@gericdong
Copy link
Collaborator

The CI test was aborted because the featurestore test timed out the test run, as message shown below. The CI will be rerun once the featurestore test is stable.

AI platform create featurestore with fixed nodes
Error: The operation was canceled.

@telpirion
Copy link
Contributor Author

If the Featurestore tests are a known source of flaky test, we might want to set them to ignore/skip.

@gericdong
Copy link
Collaborator

Agree. Another repo is also temporarily skipping featurestore tests.

@telpirion telpirion merged commit 2e78e88 into main Jun 26, 2023
12 of 13 checks passed
@telpirion telpirion deleted the vertex-llm-tune branch June 26, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants