Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix env vars in scheduled runs #3459

Merged
merged 8 commits into from
Aug 16, 2023
Merged

test: fix env vars in scheduled runs #3459

merged 8 commits into from
Aug 16, 2023

Conversation

kweinmeister
Copy link
Collaborator

Some scheduled runs (example) are showing an error because the environment variable has already been defined. Restructuring the workflow to avoid this issue.

@kweinmeister kweinmeister changed the title Fix flakybot test test: fix env vars in scheduled runs Aug 15, 2023
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Aug 15, 2023
@kweinmeister kweinmeister marked this pull request as ready for review August 15, 2023 21:20
@kweinmeister kweinmeister requested review from a team as code owners August 15, 2023 21:20
@kweinmeister
Copy link
Collaborator Author

Since this change is affecting a workflow file, CI is linting the whole repo. It looks like we have a few unfixed issues that are unrelated that we can tackle outside of this PR.

Copy link
Contributor

@pattishin pattishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@pattishin pattishin merged commit b579864 into main Aug 16, 2023
30 of 31 checks passed
@pattishin pattishin deleted the fix-flakybot-test branch August 16, 2023 17:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants