Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needs to new koa const for koa v 2 to work #351

Closed
wants to merge 1 commit into from

Conversation

emcwilliams
Copy link

I was just reading through your tutorial in the Google App Engine kao intro and ran into Koa v2 requiring the "new" statement. Just wanted to give you the info to help out on the documentation. This doesn't look like the same code as in the example but maybe the message will reach you and I can sleep tonight knowing I helped fix something today :D

I was just reading through your tutorial in the Google App Engine kao intro and ran into Koa v2 requiring the "new" statement.  Just wanted to give you the info to help out on the documentation.  This doesn't look like the same code as in the example but maybe the message will reach you and I can sleep tonight knowing I helped fix something today :D
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@@ -17,6 +17,7 @@

// [START server]
const app = require('koa')();
const app = new koa();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to replace the line above it?

@fhinkel
Copy link
Contributor

fhinkel commented Jun 5, 2018

@emcwilliams Thanks for the PR! Do you want to make the requested changes?

ace-n pushed a commit that referenced this pull request Nov 14, 2022
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
kweinmeister pushed a commit that referenced this pull request Nov 18, 2022
NimJay pushed a commit that referenced this pull request Nov 18, 2022
* updated CHANGELOG.md

* updated package.json

* updated samples/package.json
ace-n pushed a commit that referenced this pull request Nov 21, 2022
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
ace-n pushed a commit that referenced this pull request Nov 21, 2022
* updated CHANGELOG.md [ci skip]

* updated package.json [ci skip]

* updated samples/package.json [ci skip]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants