Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update README.md. Fix --set-env-var to --set-env-vars #3557

Closed
wants to merge 1 commit into from

Conversation

sbleru
Copy link

@sbleru sbleru commented Oct 29, 2023

Description

This error happened, so fix option.

ERROR: (gcloud.run.deploy) unrecognized arguments:
  --set-env-var (did you mean '--set-env-vars'?)

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

This error happened.
```
ERROR: (gcloud.run.deploy) unrecognized arguments:
  --set-env-var (did you mean '--set-env-vars'?)
```
@google-cla
Copy link

google-cla bot commented Oct 29, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. labels Oct 29, 2023
@glasnt glasnt added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 1, 2023
@pattishin
Copy link
Contributor

Appreciate the change - will need to close out due to the absence of a cla.

@pattishin pattishin closed this Nov 3, 2023
pattishin added a commit that referenced this pull request Nov 3, 2023
pattishin added a commit that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: run Issues related to the Cloud Run API. asset: pattern DEE Asset tagging - Pattern. cla: no This human has *not* signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants