Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud Functions ImageMagick sample. #361

Merged
merged 1 commit into from
Apr 25, 2017
Merged

Add Cloud Functions ImageMagick sample. #361

merged 1 commit into from
Apr 25, 2017

Conversation

jmdobry
Copy link
Member

@jmdobry jmdobry commented Apr 25, 2017

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #361 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #361   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files           4        4           
  Lines         422      422           
=======================================
  Hits          354      354           
  Misses         68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce94259...b0b0cb8. Read the comment docs.

Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - comments are the questions/possible improvements I had in mind.

* Replace `YOUR_BUCKET_NAME` with the name of your image Cloud Storage Bucket.
* Replace `YOUR_STAGE_BUCKET_NAME` with the name of your Cloud Storage Bucket.

1. Upload an offensive image to your image Storage bucket, such as this image of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NSFW warning? 😛

@@ -0,0 +1,105 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought: do we want to add any system tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functions samples are all unit tests for now.

@jmdobry jmdobry merged commit 70fc057 into master Apr 25, 2017
@jmdobry jmdobry deleted the functions-image branch April 25, 2017 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants