Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added samples for secrets with labels #3728

Merged
merged 7 commits into from
Jul 31, 2024

Conversation

vipul7499
Copy link
Contributor

@vipul7499 vipul7499 commented Jul 1, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@vipul7499 vipul7499 requested review from a team as code owners July 1, 2024 10:30
Copy link

snippet-bot bot commented Jul 1, 2024

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: secretmanager Issues related to the Secret Manager API. labels Jul 1, 2024
@vipul7499 vipul7499 changed the title Added samples for secrets with labels feat : Added samples for secrets with labels Jul 3, 2024
@vipul7499 vipul7499 changed the title feat : Added samples for secrets with labels Added samples for secrets with labels Jul 3, 2024
@vipul7499 vipul7499 force-pushed the 350386524 branch 3 times, most recently from 6bdfc54 to 6af0af3 Compare July 3, 2024 04:43
@vipul7499 vipul7499 changed the title Added samples for secrets with labels feat: Added samples for secrets with labels Jul 3, 2024

'use strict';

async function main(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit (for all samples): I don't think it's good practice to have default values since the sample will fail confusingly for users not running it with the correct values. I think its better to leave them empty so that the user gets a message as to why it fails. Plus, you have the sample values in the comments anyways.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@sofisl sofisl added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 4, 2024
@subfuzion subfuzion self-requested a review July 18, 2024 16:46
@subfuzion subfuzion self-assigned this Jul 18, 2024
@subfuzion
Copy link
Member

subfuzion commented Jul 18, 2024

Hi @vipul7499, the CI test is failing because certain workflows can't be run from a fork. Please resubmit this pull request using a branch on this repo instead of your fork. I confirmed that your pull request will pass tests once you do this. Thanks!

@Sita04
Copy link
Contributor

Sita04 commented Jul 18, 2024

@vipul7499 LGTM from dee-infra. Will look out for your new PR from the branch as @subfuzion mentioned.

@vipul7499
Copy link
Contributor Author

Hey, @Sita04 @subfuzion I am unable to create a branch because i do not have required permissions.

@subfuzion
Copy link
Member

@vipul7499

Hey, @Sita04 @subfuzion I am unable to create a branch because i do not have required permissions.

Please work with your team to follow the process for getting access already mentioned in internal chat. Thank you.

Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vipul7499 we need to chat about this set of samples.

@vipul7499
Copy link
Contributor Author

Hey @iennae , Can you please post your concern regarding the samples?

@iennae
Copy link
Contributor

iennae commented Jul 24, 2024

Hey @iennae , Can you please post your concern regarding the samples?

We are meeting with @Sita04 to discuss the set of samples next week. Thanks for your patience.

@vipul7499 vipul7499 requested a review from a team as a code owner July 31, 2024 09:10
@vipul7499 vipul7499 changed the base branch from main to SM-labels July 31, 2024 09:11
@vipul7499 vipul7499 merged commit 22c26c4 into GoogleCloudPlatform:SM-labels Jul 31, 2024
6 of 27 checks passed
@vipul7499 vipul7499 deleted the 350386524 branch July 31, 2024 09:11
@vipul7499
Copy link
Contributor Author

@subfuzion
#3767
Updated PR with the branch in the main repo instead of fork ^

vipul7499 added a commit that referenced this pull request Aug 12, 2024
* feat: Added samples for secrets with labels (#3728)

* feat: Added samples for secrets with labels

* feat: Added samples for secrets with labels

* fix: Linting fix

* fix: remoing unwanted change

* fix: remove default values for params

---------

Co-authored-by: Adam Ross <adamross@google.com>

* fix: updated tests

---------

Co-authored-by: Adam Ross <adamross@google.com>
Co-authored-by: Tony Pujals <subfuzion@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants