Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compute_hyperdisk_create_from_pool #3800

Merged
merged 13 commits into from
Aug 23, 2024

Conversation

gryczj
Copy link
Contributor

@gryczj gryczj commented Aug 21, 2024

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Aug 21, 2024
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 21, 2024
@gryczj gryczj force-pushed the compute-hyperdisk-create-from-pool branch from 674c882 to 3f6cb7b Compare August 21, 2024 13:40
@gryczj gryczj self-assigned this Aug 21, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 21, 2024
@gryczj gryczj marked this pull request as ready for review August 21, 2024 13:48
@gryczj gryczj requested review from a team as code owners August 21, 2024 13:48
Copy link

snippet-bot bot commented Aug 21, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gryczj gryczj force-pushed the compute-hyperdisk-create-from-pool branch 2 times, most recently from 3020fd6 to 10f0e05 Compare August 22, 2024 08:56
@gryczj

This comment was marked as resolved.

@gryczj gryczj marked this pull request as draft August 22, 2024 10:02
@gryczj gryczj force-pushed the compute-hyperdisk-create-from-pool branch 3 times, most recently from 5866c23 to 88e40e8 Compare August 22, 2024 12:37
@gryczj gryczj marked this pull request as ready for review August 22, 2024 12:38
Copy link
Member

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, ready to merge after you make the requested change. Thank you!

compute/test/createComputeHyperdiskFromPool.test.js Outdated Show resolved Hide resolved
@gryczj gryczj force-pushed the compute-hyperdisk-create-from-pool branch 3 times, most recently from 0cc6d7e to 77197d9 Compare August 23, 2024 09:35
@gryczj gryczj force-pushed the compute-hyperdisk-create-from-pool branch from 77197d9 to 131d75c Compare August 23, 2024 09:49
@subfuzion subfuzion merged commit c08518a into main Aug 23, 2024
32 checks passed
@subfuzion subfuzion deleted the compute-hyperdisk-create-from-pool branch August 23, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants