Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storage client to latest. #393

Merged
merged 1 commit into from
May 18, 2017
Merged

Update storage client to latest. #393

merged 1 commit into from
May 18, 2017

Conversation

jmdobry
Copy link
Member

@jmdobry jmdobry commented May 16, 2017

No description provided.

@jmdobry jmdobry self-assigned this May 16, 2017
@jmdobry jmdobry requested a review from ace-n May 16, 2017 17:00
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than a minor nit.

@@ -15,11 +15,11 @@
"lint": "samples lint",
"pretest": "npm run lint",
"unit-test": "ava -T 20s --verbose test/*.test.js",
"system-test": "ava -T 20s --verbose system-test/*.test.js",
"system-test": "ava -T 20s --verbose system-test/encryption.test.js",
Copy link
Contributor

@ace-n ace-n May 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: was this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, fixed

@jmdobry jmdobry merged commit a5b1ef4 into master May 18, 2017
@jmdobry jmdobry deleted the storage-fix branch May 18, 2017 05:56
ace-n pushed a commit that referenced this pull request Nov 14, 2022
ace-n pushed a commit that referenced this pull request Nov 21, 2022
ace-n pushed a commit that referenced this pull request Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants