[DO NOT MERGE] Update/add tests + fix dependencies #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
- Coverage 83.92% 83.84% -0.08%
==========================================
Files 4 4
Lines 423 421 -2
==========================================
- Hits 355 353 -2
Misses 68 68
Continue to review full report at Codecov.
|
|
Note/Reminder: |
jmdobry
requested changes
Aug 14, 2017
appengine/cloudsql/package.json
Outdated
| "@google-cloud/nodejs-repo-tools": "1.4.15", | ||
| "ava": "0.19.1" | ||
| }, | ||
| "cloud-repo-tools": { |
There was a problem hiding this comment.
tldr; from our convo, revert changes to "cloud-repo-tools" and the 2 new .js test files, and instead update circle.yml
appengine/pubsub/app.js
Outdated
| const process = require('process'); // Required for mocking environment variables | ||
|
|
||
| // Make sure starting directory is consistent, so that views are found correctly | ||
| process.chdir(__dirname); |
There was a problem hiding this comment.
Instead of this wonkiness, explicitly tell express where to look for views.
| @@ -2,16 +2,17 @@ | |||
| "name": "appengine-storage", | |||
| "description": "Node.js Google Cloud Storage sample for Google App Engine", | |||
| "scripts": { | |||
| "start": "node app.js" | |||
| "start": "node app.js", | |||
| "test": "ava system-test/*.test.js -T 30s" | |||
There was a problem hiding this comment.
Change this to:
"test": "GOOGLE_STORAGE_BUCKET=$(uuidgen) samples test app && ava system-test/*.test.js -T 30s"
AND
add a "cloud-repo-tools" to the package.json that includes a "requiredEnvVars" clause
AND
delete your config file
AND
Add a line to circle.yml to invoke this test
AND
apply these comments to other appengine apps that you modified.
This was referenced Aug 21, 2017
|
Can potentially close this in favor of #463 |
|
This was replaced by #468. |
This was referenced Jan 12, 2022
[Snyk] Security upgrade @google-cloud/pubsub from 0.22.2 to 0.24.0
leejh3224/nodejs-docs-samples#420
Open
[Snyk] Security upgrade @google-cloud/pubsub from 0.22.2 to 0.24.0
leejh3224/nodejs-docs-samples#422
Open
[Snyk] Security upgrade @google-cloud/pubsub from 0.22.2 to 0.24.0
leejh3224/nodejs-docs-samples#438
Open
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
* build!: Update library to use Node 12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
* build!: Update library to use Node 12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
* build!: Update library to use Node 12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 15, 2022
* build!: Update library to use Node 12 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 18, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 18, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 18, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until this PR is included in a tagged version of
nodejs-repo-tools. (The tests will fail otherwise.)Also - this is definitely not the last PR on this topic. (There will probably be 2-4 more as I context-switch between things.)