-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KMS: Makes samples consistent across languages. #459
KMS: Makes samples consistent across languages. #459
Conversation
This change, in particular: * Consistently names variables with the API (locationId, keyRingId, cryptoKeyId). * Displays the function name in the region tag. * Correctly writes decoded base64 to disk and encodes file contents before calling KMS. * Labels parameters as plaintextFileName and ciphertextFileName, rather than inFile and outFile where applicable. Tracking bug: http://b/64758639
I agree with most of these changes, save for the region tag modifications. These snippets are meant to be standalone pieces of code that can be run without being wrapped in a function - the sole purpose of the @jmdobry might have something to add though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ace-n is right. The variable name changes are fine, but the region tags need to go back to the way they were. Otherwise LGTM.
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
===========================================
- Coverage 83.92% 13.46% -70.47%
===========================================
Files 4 3 -1
Lines 423 208 -215
===========================================
- Hits 355 28 -327
- Misses 68 180 +112
Continue to review full report at Codecov.
|
SGTM, thanks for the quick response. Fixed. |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
- [x] Ensure the tests and linter pass - [ obviously a decrease...] Code coverage does not decrease (if any source code was changed) - [please review] Appropriate docs were updated (if necessary) Samples are not in localized docs nor on C.G.C. These deletions are part of an internal 'clean-up' to reduce unused code in sample repositories.
- [x] Ensure the tests and linter pass - [ obviously a decrease...] Code coverage does not decrease (if any source code was changed) - [please review] Appropriate docs were updated (if necessary) Samples are not in localized docs nor on C.G.C. These deletions are part of an internal 'clean-up' to reduce unused code in sample repositories.
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
This change, in particular:
cryptoKeyId).
before calling KMS.
than inFile and outFile where applicable.
Tracking bug: http://b/64758639