Final additions in private beta #489

gguuss · 2017-09-22T22:03:27Z

No description provided.

dizcology

Not sure how easy it would be to add tests for the codes in http_example/. If it is easy and makes sense to have them, please consider adding some tests.

dizcology · 2017-09-25T21:16:59Z

iot/http_example/README.md

+
+# Google Cloud IoT Core NodeJS HTTP example
+
+This sample app publishes messages to Cloud Pub/Sub or states using the HTTP


I don't understand what "Cloud Pub/Sub or states" means.

dizcology · 2017-09-25T21:18:04Z

iot/http_example/cloudiot.rest.json

@@ -0,0 +1,279 @@
+{


What is this file for?

Removed, the device API was to be exposed as Apiary via device REST discovery.

dizcology · 2017-09-25T21:20:12Z

iot/http_example/cloudiot_http_example_nodejs.js

+        description: 'Encryption algorithm to generate the JWT.',
+        requiresArg: true,
+        demandOption: true,
+        choices: ['RS256', 'ES256'],


If the target user of this sample is expected to be familiar with JWT, or node already prints allowed choices, then please ignore my comment:

It might help to print the allowed choices in the help/description message.

dizcology · 2017-09-25T21:31:46Z

iot/http_example/cloudiot_http_example_nodejs.js

+// messageCount. Telemetry events are published at a rate of 1 per second and
+// states at a rate of 1 every 2 seconds.
+function publishAsync (messageCount, numMessages) {
+  const payload = `${argv.registry_id}/${argv.device_id}-payload-${messageCount}`;


The publishAsync function in http_client_example.js seems more flexible allowing the user to specify a message argument. Why is the publishAsync function in this file not allowing the same?

Checked in duplicate versions of the same sample, will clean up after dinner.

dizcology · 2017-09-25T21:37:01Z

iot/http_example/http_client_example.js

+  console.log('Publishing to:', path);
+  console.log('Publishing message:', message);
+
+  // TODO: Publish message hurr


Still need to do this?

Removed extra implementation,

dizcology · 2017-09-25T21:40:13Z

iot/http_example/http_client_example.js

+
+// Publish numMessages messages asynchronously, starting from message
+// messageCount.
+function publishAsync (bearer, client, messageCount, message, projectId, cloudRegion, registryId, deviceId) {


The order of arguments is a bit inconsistent:

for this function: (bearer, client, messageCount, message, projectId, cloudRegion, registryId, deviceId)

for getDeviceState in manager.js it is (client, deviceId, registryId, projectId, cloudRegion)

gguuss

This will be difficult to setup tests for because it depends on a lot of components being in place both in order to run the sample as well as being able to measure the sample is working.

…/nodejs-docs-samples into iot-snippets

🤖 I have created a release \*beep\* \*boop\* --- ## [2.6.0](https://www.github.com/googleapis/nodejs-kms/compare/v2.5.0...v2.6.0) (2021-08-17) ### Features * **kms:** add samples for new rng and hmac kms apis ([#487](https://www.github.com/googleapis/nodejs-kms/issues/487)) ([5278a8e](https://www.github.com/googleapis/nodejs-kms/commit/5278a8e62c14fcc5cc02e4bd7b36e68a4ed48b72)) ### Bug Fixes * **deps:** google-gax v2.24.1 ([#489](https://www.github.com/googleapis/nodejs-kms/issues/489)) ([f5e8569](https://www.github.com/googleapis/nodejs-kms/commit/f5e85696de33d8870951d684b491338fc3c029f3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Final additions in private beta

e47f4c3

gguuss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 22, 2017

gguuss added 2 commits September 25, 2017 12:26

Changes to registry create

e670a34

Adds HTTP client and state support for MQTT

4c83c85

dizcology reviewed Sep 25, 2017

View reviewed changes

gguuss added 2 commits September 25, 2017 15:53

Removes extra code and discovery doc

d4ecd50

Add product link to readme, options to yargs.

915d197

gguuss commented Sep 26, 2017

View reviewed changes

Merge branch 'master' into iot-snippets

02fa580

gguuss removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 26, 2017

gguuss added 5 commits September 26, 2017 12:45

Add license to package.json

562e952

Adds includecode blocks to MQTT / HTTP

9e8af84

Merge branch 'iot-snippets' of https://github.com/GoogleCloudPlatform…

7682821

…/nodejs-docs-samples into iot-snippets

Fix lint

ddc4231

Adds comment on state vs event frequency

930b9fd

gguuss merged commit 5d90464 into master Sep 26, 2017

gguuss deleted the iot-snippets branch September 26, 2017 23:34

This was referenced Dec 23, 2020

[Snyk] Security upgrade @google-cloud/firestore from 0.19.0 to 0.21.0 leejh3224/nodejs-docs-samples#285

Open

[Snyk] Security upgrade @google-cloud/firestore from 0.19.0 to 0.21.0 leejh3224/nodejs-docs-samples#309

Open

This was referenced Sep 6, 2021

[Snyk] Security upgrade @google-cloud/firestore from 0.19.0 to 0.21.0 leejh3224/nodejs-docs-samples#359

Open

[Snyk] Security upgrade @google-cloud/firestore from 0.19.0 to 0.21.0 leejh3224/nodejs-docs-samples#363

Open

This was referenced Jan 12, 2022

[Snyk] Security upgrade @google-cloud/firestore from 0.19.0 to 0.21.0 leejh3224/nodejs-docs-samples#434

Open

[Snyk] Security upgrade @google-cloud/firestore from 0.19.0 to 0.21.0 leejh3224/nodejs-docs-samples#437

Open

This was referenced Feb 10, 2022

[Snyk] Security upgrade @google-cloud/firestore from 0.19.0 to 0.21.0 leejh3224/nodejs-docs-samples#455

Open

[Snyk] Security upgrade @google-cloud/firestore from 0.19.0 to 0.21.0 leejh3224/nodejs-docs-samples#466

Open

ace-n pushed a commit that referenced this pull request Nov 16, 2022

chore: release 3.1.0 (#489)

e68cabd

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ace-n mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-video-intelligence #2855

Merged

ace-n pushed a commit that referenced this pull request Nov 17, 2022

chore: release 3.1.0 (#489)

f0db7ba

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

unforced pushed a commit that referenced this pull request Nov 17, 2022

chore(deps): update dependency @google-cloud/pubsub to v3 (#489)

ec6261d

unforced mentioned this pull request Nov 17, 2022

migrate code from googleapis/nodejs-security-center #2867

Merged

ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022

chore: release 3.1.0 (#489)

ffe8bee

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Final additions in private beta #489

Final additions in private beta #489

gguuss commented Sep 22, 2017

dizcology left a comment

dizcology Sep 25, 2017

dizcology Sep 25, 2017

gguuss Sep 26, 2017

dizcology Sep 25, 2017

dizcology Sep 25, 2017

gguuss Sep 26, 2017

dizcology Sep 25, 2017

gguuss Sep 26, 2017

dizcology Sep 25, 2017

gguuss left a comment


		# Google Cloud IoT Core NodeJS HTTP example

		This sample app publishes messages to Cloud Pub/Sub or states using the HTTP

Final additions in private beta #489

Final additions in private beta #489

Conversation

gguuss commented Sep 22, 2017

dizcology left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gguuss left a comment

Choose a reason for hiding this comment