Add missing pub-sub samples #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2017 17:51
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 13 13
Lines 458 458
=======================================
Hits 445 445
Misses 13 13Continue to review full report at Codecov.
|
jmdobry
reviewed
Oct 24, 2017
| @@ -84,6 +84,32 @@ function createSubscription (topicName, subscriptionName) { | |||
| } | |||
| // [END pubsub_create_subscription] | |||
|
|
|||
| // [START pubsub_subscriber_flow_settings] | |||
| function createFlowControlledSubscription (topicName, subscriptionName, maxInProgress, maxBytes) { | |||
There was a problem hiding this comment.
I guess the Pub/Sub samples were never updated to hide the method definition?
There was a problem hiding this comment.
Correct - I can address that in a separate PR, if you'd like.
jmdobry
reviewed
Oct 24, 2017
| console.log(`Subscription ${subscription.name} created with a maximum of ${maxInProgress} unprocessed messages.`); | ||
|
|
||
| return subscription; | ||
| }); |
There was a problem hiding this comment.
And weren't updated to handle errors.
There was a problem hiding this comment.
Correct - see above comment.
jmdobry
approved these changes
Oct 24, 2017
NimJay
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [2.9.0](https://www.github.com/googleapis/nodejs-kms/compare/v2.8.1...v2.9.0) (2021-10-14) ### Features * add OAEP+SHA1 to the list of supported algorithms ([#503](https://www.github.com/googleapis/nodejs-kms/issues/503)) ([00cc42e](https://www.github.com/googleapis/nodejs-kms/commit/00cc42ed9a30650fc88d27c8205e08bb305dd0f8)) * add RPC retry information for MacSign, MacVerify, and GenerateRandomBytes Committer: [@bdhess](https://www.github.com/bdhess) ([#506](https://www.github.com/googleapis/nodejs-kms/issues/506)) ([08cd155](https://www.github.com/googleapis/nodejs-kms/commit/08cd15524662ba81a35761df592ea8ce1557e023)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [2.9.0](https://www.github.com/googleapis/nodejs-kms/compare/v2.8.1...v2.9.0) (2021-10-14) ### Features * add OAEP+SHA1 to the list of supported algorithms ([#503](https://www.github.com/googleapis/nodejs-kms/issues/503)) ([00cc42e](https://www.github.com/googleapis/nodejs-kms/commit/00cc42ed9a30650fc88d27c8205e08bb305dd0f8)) * add RPC retry information for MacSign, MacVerify, and GenerateRandomBytes Committer: [@bdhess](https://www.github.com/bdhess) ([#506](https://www.github.com/googleapis/nodejs-kms/issues/506)) ([08cd155](https://www.github.com/googleapis/nodejs-kms/commit/08cd15524662ba81a35761df592ea8ce1557e023)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @jabubake