Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigquery-stream-data-nodejs docs - use correct json property to check for errors #519

Closed
wants to merge 1 commit into from
Closed

bigquery-stream-data-nodejs docs - use correct json property to check for errors #519

wants to merge 1 commit into from

Conversation

blundell
Copy link

@blundell blundell commented Nov 8, 2017 •
edited
Loading

Fix from the documentation here:

https://cloud.google.com/bigquery/streaming-data-into-bigquery#bigquery-stream-data-nodejs

  • name json correctly and then use the correct child value to check for errors
  • also log in a way that doesn't matter if you read logs top down or bottom up (i.e. firebase function logs vs cmd line)
  • use JSON.stringify for more readable output

paired with @ouchadam

@blundell
use correct json property to check for errors
f498afc 
name json correctly and then use the correct child value to check for errors
also log in a way that doesn't matter if you read logs top down or bottom up (i.e. firebase function logs vs cmd line)
@blundell
Copy link
Author

blundell commented Nov 9, 2017

screen shot 2017-11-09 at 10 00 19 pm

not sure the failure is something I (a non admin) can fix?

@jmdobry
Copy link
Member

jmdobry commented Dec 8, 2017

Thanks for this, I moved the fix to here: https://github.com/googleapis/nodejs-bigquery/pull/29/files#diff-41e74da76efff7f0fbf13acaed97ec9e

@jmdobry jmdobry closed this Dec 8, 2017
@snyk-bot snyk-bot mentioned this pull request Jan 31, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Dec 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Sep 6, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 10, 2022
Open
This was referenced Apr 7, 2022
Open
Open
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 3.15.1 (#519)
219328f 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.15.1](https://www.github.com/googleapis/nodejs-asset/compare/v3.15.0...v3.15.1) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#514](https://www.github.com/googleapis/nodejs-asset/issues/514)) ([85e0ebd](https://www.github.com/googleapis/nodejs-asset/commit/85e0ebd92f326ce52f3a920a8cea9d392ff821b5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 3.15.1 (#519)
dc0b1fa 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.15.1](https://www.github.com/googleapis/nodejs-asset/compare/v3.15.0...v3.15.1) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#514](https://www.github.com/googleapis/nodejs-asset/issues/514)) ([85e0ebd](https://www.github.com/googleapis/nodejs-asset/commit/85e0ebd92f326ce52f3a920a8cea9d392ff821b5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 3.15.1 (#519)
ae090b0 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.15.1](https://www.github.com/googleapis/nodejs-asset/compare/v3.15.0...v3.15.1) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#514](https://www.github.com/googleapis/nodejs-asset/issues/514)) ([85e0ebd](https://www.github.com/googleapis/nodejs-asset/commit/85e0ebd92f326ce52f3a920a8cea9d392ff821b5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 3.15.1 (#519)
9656e7b 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.15.1](https://www.github.com/googleapis/nodejs-asset/compare/v3.15.0...v3.15.1) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#514](https://www.github.com/googleapis/nodejs-asset/issues/514)) ([85e0ebd](https://www.github.com/googleapis/nodejs-asset/commit/85e0ebd92f326ce52f3a920a8cea9d392ff821b5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 3.15.1 (#519)
eb3bdb9 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.15.1](https://www.github.com/googleapis/nodejs-asset/compare/v3.15.0...v3.15.1) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#514](https://www.github.com/googleapis/nodejs-asset/issues/514)) ([85e0ebd](https://www.github.com/googleapis/nodejs-asset/commit/85e0ebd92f326ce52f3a920a8cea9d392ff821b5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 16, 2022
Merged
grayside pushed a commit that referenced this pull request Nov 16, 2022
@Shabirmean @gcf-owl-bot
docs(samples): add usage samples to show handling of LRO response Ope…
b2c7e9f 
…ration (#519)

* improvements: add samples

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: add tests for the samples

* fix: merge conflict

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* cleanup: rearrange region tags

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: replace beforeEach with before

* fix: failing test cases

* cleanup: rearrange code lines

* test: fix the timeout and race issues in tests

* cleanup: rename fn

* fix: mocha test definition

* cleanup: change console log

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: failing test due package

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: linting errors

* fix: add netowkr as arg

* lint: fix test js

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: add ci network to test

* cleanup: ammend as per PR comments

* cleanup: remove unused dep

* fix: test case

* doc: add explanation to the test util file

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* doc: fix typos

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* lint: fix errors

* fix: move after block

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@grayside grayside mentioned this pull request Nov 16, 2022
Closed
grayside pushed a commit that referenced this pull request Nov 16, 2022
@Shabirmean @gcf-owl-bot
docs(samples): add usage samples to show handling of LRO response Ope…
1976d4f 
…ration (#519)

* improvements: add samples

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: add tests for the samples

* fix: merge conflict

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* cleanup: rearrange region tags

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: replace beforeEach with before

* fix: failing test cases

* cleanup: rearrange code lines

* test: fix the timeout and race issues in tests

* cleanup: rename fn

* fix: mocha test definition

* cleanup: change console log

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: failing test due package

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: linting errors

* fix: add netowkr as arg

* lint: fix test js

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: add ci network to test

* cleanup: ammend as per PR comments

* cleanup: remove unused dep

* fix: test case

* doc: add explanation to the test util file

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* doc: fix typos

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* lint: fix errors

* fix: move after block

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
grayside pushed a commit that referenced this pull request Nov 16, 2022
@Shabirmean @gcf-owl-bot
docs(samples): add usage samples to show handling of LRO response Ope…
d66f4ff 
…ration (#519)

* improvements: add samples

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: add tests for the samples

* fix: merge conflict

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* cleanup: rearrange region tags

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: replace beforeEach with before

* fix: failing test cases

* cleanup: rearrange code lines

* test: fix the timeout and race issues in tests

* cleanup: rename fn

* fix: mocha test definition

* cleanup: change console log

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: failing test due package

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: linting errors

* fix: add netowkr as arg

* lint: fix test js

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: add ci network to test

* cleanup: ammend as per PR comments

* cleanup: remove unused dep

* fix: test case

* doc: add explanation to the test util file

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* doc: fix typos

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* lint: fix errors

* fix: move after block

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@grayside grayside mentioned this pull request Nov 16, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@Shabirmean @gcf-owl-bot
docs(samples): add usage samples to show handling of LRO response Ope…
535ab10 
…ration (#519)

* improvements: add samples

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: add tests for the samples

* fix: merge conflict

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* cleanup: rearrange region tags

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: replace beforeEach with before

* fix: failing test cases

* cleanup: rearrange code lines

* test: fix the timeout and race issues in tests

* cleanup: rename fn

* fix: mocha test definition

* cleanup: change console log

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: failing test due package

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: linting errors

* fix: add netowkr as arg

* lint: fix test js

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: add ci network to test

* cleanup: ammend as per PR comments

* cleanup: remove unused dep

* fix: test case

* doc: add explanation to the test util file

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* doc: fix typos

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* lint: fix errors

* fix: move after block

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
grayside pushed a commit that referenced this pull request Nov 17, 2022
@Shabirmean @gcf-owl-bot @grayside
docs(samples): add usage samples to show handling of LRO response Ope…
031f71f 
…ration (#519)

* improvements: add samples

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: add tests for the samples

* fix: merge conflict

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* cleanup: rearrange region tags

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: replace beforeEach with before

* fix: failing test cases

* cleanup: rearrange code lines

* test: fix the timeout and race issues in tests

* cleanup: rename fn

* fix: mocha test definition

* cleanup: change console log

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: failing test due package

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: linting errors

* fix: add netowkr as arg

* lint: fix test js

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: add ci network to test

* cleanup: ammend as per PR comments

* cleanup: remove unused dep

* fix: test case

* doc: add explanation to the test util file

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* doc: fix typos

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* lint: fix errors

* fix: move after block

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore: release 3.15.1 (#519)
602371d 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.15.1](https://www.github.com/googleapis/nodejs-asset/compare/v3.15.0...v3.15.1) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#514](https://www.github.com/googleapis/nodejs-asset/issues/514)) ([85e0ebd](https://www.github.com/googleapis/nodejs-asset/commit/85e0ebd92f326ce52f3a920a8cea9d392ff821b5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
@Shabirmean @gcf-owl-bot @ahrarmonsur
docs(samples): add usage samples to show handling of LRO response Ope…
e887920 
…ration (#519)

* improvements: add samples

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: add tests for the samples

* fix: merge conflict

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* cleanup: rearrange region tags

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: replace beforeEach with before

* fix: failing test cases

* cleanup: rearrange code lines

* test: fix the timeout and race issues in tests

* cleanup: rename fn

* fix: mocha test definition

* cleanup: change console log

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: failing test due package

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: linting errors

* fix: add netowkr as arg

* lint: fix test js

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* test: add ci network to test

* cleanup: ammend as per PR comments

* cleanup: remove unused dep

* fix: test case

* doc: add explanation to the test util file

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* doc: fix typos

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* lint: fix errors

* fix: move after block

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blundell @jmdobry