Update README.md to include region #524

art-tts · 2017-11-14T17:28:01Z

Including region in example, if you're in Europe the example will not work, and will instead spit out errors.

googlebot · 2017-11-14T17:28:04Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

codecov · 2017-11-14T17:35:47Z

Codecov Report

Merging #524 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #524   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          13       13           
  Lines         458      458           
=======================================
  Hits          445      445           
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6886ef8...902c8fc. Read the comment docs.

art-tts · 2017-11-14T17:42:35Z

I signed it!

gguuss · 2017-12-14T21:56:53Z

iot/mqtt_example/README.md

@@ -46,6 +46,7 @@ run the sample as:
        --registry_id=my-registry \
        --device_id=my-node-device \
        --private_key_file=../rsa_private.pem \
+        --cloud_region=us-west1 \


Nit. I'm not 100% sure we're in the us-west1 region yet, can you change this to us-central1, europe-west1, or asia-east1?

Did you verify? I can modify.

I did, us-central1 is definitely supported, others I didn't list are not showing up for me.

googlebot · 2017-12-18T18:14:41Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

gguuss · 2017-12-18T18:15:05Z

@googlebot I signed it!

fhinkel · 2018-06-05T20:15:46Z

@art-tts Thanks for the PR! Do you want to make the requested change?

gguuss · 2018-07-17T18:30:22Z

Closing, instructions must have been updated in a separate PR.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Co-authored-by: Nicole Zhu <69952136+nicoleczhu@users.noreply.github.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.1](https://www.github.com/googleapis/nodejs-compute/compare/v2.4.0...v2.4.1) (2020-11-25) ### Bug Fixes * skip tests for now ([#523](https://www.github.com/googleapis/nodejs-compute/issues/523)) ([f0f8fae](https://www.github.com/googleapis/nodejs-compute/commit/f0f8faee962b5463b26c7551adae67a724875a55)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [2.4.1](https://www.github.com/googleapis/nodejs-compute/compare/v2.4.0...v2.4.1) (2020-11-25) ### Bug Fixes * skip tests for now ([#523](https://www.github.com/googleapis/nodejs-compute/issues/523)) ([f0f8fae](https://www.github.com/googleapis/nodejs-compute/commit/f0f8faee962b5463b26c7551adae67a724875a55)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

Update README.md to include region

3534ff7

Including region in example, if you're in Europe the example will not work, and will instead spit out errors.

jmdobry requested a review from gguuss December 8, 2017 17:48

jmdobry assigned gguuss Dec 8, 2017

gguuss reviewed Dec 14, 2017

View reviewed changes

Merge branch 'master' into patch-1

902c8fc

gguuss closed this Jul 17, 2018

snyk-bot mentioned this pull request Jan 31, 2020

[Snyk] Fix for 1 vulnerabilities leejh3224/nodejs-docs-samples#158

Open

ahrarmonsur pushed a commit that referenced this pull request Nov 8, 2022

chore: release 2.3.0 (#524)

7bcf8ab

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

ahrarmonsur mentioned this pull request Nov 8, 2022

samples: migrate code from googleapis/nodejs-monitoring #2807

Merged

ace-n pushed a commit that referenced this pull request Nov 10, 2022

chore: release 2.3.0 (#524)

f800984

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

kweinmeister pushed a commit that referenced this pull request Nov 10, 2022

chore(deps): update dependency gaxios to v4 (#524)

5a1d63a

Co-authored-by: Nicole Zhu <69952136+nicoleczhu@users.noreply.github.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>

kweinmeister mentioned this pull request Nov 10, 2022

migrate code from googleapis/nodejs-error-reporting #2821

Merged

ace-n pushed a commit that referenced this pull request Nov 11, 2022

chore(deps): update dependency gaxios to v4 (#524)

234a836

Co-authored-by: Nicole Zhu <69952136+nicoleczhu@users.noreply.github.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>

ace-n pushed a commit that referenced this pull request Nov 11, 2022

chore(deps): update dependency gaxios to v4 (#524)

c52ae54

Co-authored-by: Nicole Zhu <69952136+nicoleczhu@users.noreply.github.com> Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>

ace-n mentioned this pull request Nov 14, 2022

migrate code from googleapis/nodejs-compute #2846

Closed

ace-n mentioned this pull request Nov 15, 2022

migrate code from googleapis/nodejs-compute #2853

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update README.md to include region #524

Update README.md to include region #524

art-tts commented Nov 14, 2017

googlebot commented Nov 14, 2017

codecov bot commented Nov 14, 2017 •

edited

Loading

art-tts commented Nov 14, 2017

gguuss Dec 14, 2017

art-tts Dec 18, 2017

gguuss Dec 20, 2017

googlebot commented Dec 18, 2017

gguuss commented Dec 18, 2017

fhinkel commented Jun 5, 2018

gguuss commented Jul 17, 2018

Update README.md to include region #524

Update README.md to include region #524

Conversation

art-tts commented Nov 14, 2017

googlebot commented Nov 14, 2017

codecov bot commented Nov 14, 2017 • edited Loading

Codecov Report

art-tts commented Nov 14, 2017

gguuss Dec 14, 2017

Choose a reason for hiding this comment

art-tts Dec 18, 2017

Choose a reason for hiding this comment

gguuss Dec 20, 2017

Choose a reason for hiding this comment

googlebot commented Dec 18, 2017

gguuss commented Dec 18, 2017

fhinkel commented Jun 5, 2018

gguuss commented Jul 17, 2018

codecov bot commented Nov 14, 2017 •

edited

Loading