Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System-ify functions tests, part 1 (hello-world + datastore) #529

Merged
merged 25 commits into from
Jan 4, 2018

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Dec 4, 2017

Do not merge yet - this PR removes a sample that's still in the docs.

@ace-n ace-n added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 4, 2017
@ace-n ace-n requested a review from jmdobry December 4, 2017 21:47
@GoogleCloudPlatform GoogleCloudPlatform deleted a comment from googlebot Dec 4, 2017
@codecov
Copy link

codecov bot commented Dec 5, 2017

Codecov Report

Merging #529 into master will increase coverage by 2.83%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #529      +/-   ##
========================================
+ Coverage   97.16%   100%   +2.83%     
========================================
  Files          13      1      -12     
  Lines         458      3     -455     
========================================
- Hits          445      3     -442     
+ Misses         13      0      -13
Impacted Files Coverage Δ
functions/slack/index.js
functions/background/index.js
functions/pubsub/index.js
functions/gcs/index.js
functions/imagemagick/index.js
functions/spanner/index.js
functions/ocr/app/index.js
functions/log/index.js
functions/http/index.js
functions/sendgrid/index.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e6d00c...e21875c. Read the comment docs.

@GoogleCloudPlatform GoogleCloudPlatform deleted a comment from googlebot Dec 20, 2017
@ace-n ace-n changed the title System-ify functions tests, part 1 System-ify functions tests, part 1 (hello-world + datastore) Dec 20, 2017
@ace-n
Copy link
Contributor Author

ace-n commented Dec 20, 2017

@jmdobry This should be good to review, but we'll either a) need to move the Datastore CI to Kokoro or b) make sure it passes on CircleCI (which is doable, but will require installing the emulator).

@jmdobry
Copy link
Member

jmdobry commented Dec 27, 2017

Approved, do what you need to do

@ace-n ace-n merged commit 5cb34c0 into master Jan 4, 2018
@ace-n ace-n deleted the functions-tests branch January 4, 2018 22:19
grayside pushed a commit that referenced this pull request Oct 26, 2022
grayside pushed a commit that referenced this pull request Nov 3, 2022
NimJay pushed a commit that referenced this pull request Nov 10, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
NimJay pushed a commit that referenced this pull request Nov 10, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
grayside pushed a commit that referenced this pull request Nov 16, 2022
* chore(main): release 3.0.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
grayside pushed a commit that referenced this pull request Nov 16, 2022
* chore(main): release 3.0.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
grayside pushed a commit that referenced this pull request Nov 16, 2022
* chore(main): release 3.0.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
* chore(main): release 3.0.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
grayside pushed a commit that referenced this pull request Nov 17, 2022
* chore(main): release 3.0.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
* chore(main): release 3.0.1

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants