Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the function snippet syntax to ES6 standards. #542

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Updates the function snippet syntax to ES6 standards. #542

merged 1 commit into from
Jan 4, 2018

Conversation

emesx
Copy link
Contributor

@emesx emesx commented Dec 22, 2017

As discussed in the email thread.
@ace-n

@codecov
Copy link

codecov bot commented Dec 22, 2017 •
edited
Loading

Codecov Report

Merging #542 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #542   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          13       13           
  Lines         458      458           
=======================================
  Hits          445      445           
  Misses         13       13
Impacted Files Coverage Δ
functions/log/index.js 90.9% <100%> (ø) ⬆️
functions/datastore/index.js 100% <100%> (ø) ⬆️
functions/slack/index.js 100% <100%> (ø) ⬆️
functions/background/index.js 100% <100%> (ø) ⬆️
functions/uuid/index.js 100% <100%> (ø) ⬆️
functions/ocr/app/index.js 98.59% <100%> (ø) ⬆️
functions/helloworld/index.js 100% <100%> (ø) ⬆️
functions/http/index.js 100% <100%> (ø) ⬆️
functions/sendgrid/index.js 100% <100%> (ø) ⬆️
functions/pubsub/index.js 100% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80dda29...fcd2bb5. Read the comment docs.

@ace-n
Copy link
Contributor

ace-n commented Jan 4, 2018

LGTM.

@ace-n ace-n merged commit 1e6d00c into GoogleCloudPlatform:master Jan 4, 2018
@snyk-bot snyk-bot mentioned this pull request Sep 5, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2022
Open
ace-n pushed a commit that referenced this pull request Nov 14, 2022
@release-please
chore: release 2.4.3 (#542)
4a305eb 
🤖 I have created a release \*beep\* \*boop\* 
---
### [2.4.3](https://www.github.com/googleapis/nodejs-compute/compare/v2.4.2...v2.4.3) (2021-01-27)


### Bug Fixes

* handle parameters to image.create() ([#541](https://www.github.com/googleapis/nodejs-compute/issues/541)) ([3b3a7dd](https://www.github.com/googleapis/nodejs-compute/commit/3b3a7dd81790b788d5d53947e2948df55b702c93))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Nov 14, 2022
Closed
Merged
grayside pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore(main): release 4.0.1 (#542)
50db079 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Shabir Mohamed Abdul Samadh <7249208+Shabirmean@users.noreply.github.com>
@grayside grayside mentioned this pull request Nov 16, 2022
Closed
grayside pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore(main): release 4.0.1 (#542)
57986cb 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Shabir Mohamed Abdul Samadh <7249208+Shabirmean@users.noreply.github.com>
grayside pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore(main): release 4.0.1 (#542)
80107f1 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Shabir Mohamed Abdul Samadh <7249208+Shabirmean@users.noreply.github.com>
@grayside grayside mentioned this pull request Nov 16, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore(main): release 4.0.1 (#542)
ad7e7e0 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Shabir Mohamed Abdul Samadh <7249208+Shabirmean@users.noreply.github.com>
grayside pushed a commit that referenced this pull request Nov 17, 2022
@release-please @grayside
chore(main): release 4.0.1 (#542)
42398cf 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Shabir Mohamed Abdul Samadh <7249208+Shabirmean@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
@release-please @ahrarmonsur
chore(main): release 4.0.1 (#542)
c32ee6d 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Shabir Mohamed Abdul Samadh <7249208+Shabirmean@users.noreply.github.com>
@kweinmeister kweinmeister mentioned this pull request Nov 18, 2022
Merged
kweinmeister pushed a commit that referenced this pull request Nov 18, 2022
@release-please
chore: release 3.2.7 (#542)
aa0774d 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.2.7](https://www.github.com/googleapis/nodejs-text-to-speech/compare/v3.2.6...v3.2.7) (2021-08-17)


### Bug Fixes

* **deps:** google-gax v2.24.1 ([#541](https://www.github.com/googleapis/nodejs-text-to-speech/issues/541)) ([0c93b5b](https://www.github.com/googleapis/nodejs-text-to-speech/commit/0c93b5bd89bd983c1a9d658d22179b8732b533ed))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 21, 2022
@release-please
chore: release 2.4.3 (#542)
298ec5a 
🤖 I have created a release \*beep\* \*boop\* 
---
### [2.4.3](https://www.github.com/googleapis/nodejs-compute/compare/v2.4.2...v2.4.3) (2021-01-27)


### Bug Fixes

* handle parameters to image.create() ([#541](https://www.github.com/googleapis/nodejs-compute/issues/541)) ([3b3a7dd](https://www.github.com/googleapis/nodejs-compute/commit/3b3a7dd81790b788d5d53947e2948df55b702c93))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 21, 2022
@release-please
chore: release 2.4.3 (#542)
0ce3af5 
🤖 I have created a release \*beep\* \*boop\* 
---
### [2.4.3](https://www.github.com/googleapis/nodejs-compute/compare/v2.4.2...v2.4.3) (2021-01-27)


### Bug Fixes

* handle parameters to image.create() ([#541](https://www.github.com/googleapis/nodejs-compute/issues/541)) ([3b3a7dd](https://www.github.com/googleapis/nodejs-compute/commit/3b3a7dd81790b788d5d53947e2948df55b702c93))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@ninadhatkar ninadhatkar mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emesx @ace-n