Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mqtt dependency #543

Merged
merged 2 commits into from
Jan 3, 2018
Merged

Update mqtt dependency #543

merged 2 commits into from
Jan 3, 2018

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Dec 28, 2017

No description provided.

@tswast tswast requested a review from gguuss December 28, 2017 22:57
@codecov
Copy link

codecov bot commented Dec 28, 2017 •
edited
Loading

Codecov Report

Merging #543 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #543   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          13       13           
  Lines         458      458           
=======================================
  Hits          445      445           
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f230da...a88b464. Read the comment docs.

gguuss
gguuss approved these changes Jan 3, 2018
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@gguuss
Copy link
Contributor

gguuss commented Jan 3, 2018

I signed it!

@gguuss
Copy link
Contributor

gguuss commented Jan 3, 2018

@googlebot I signed it!

@gguuss gguuss merged commit 1af0e36 into master Jan 3, 2018
@jmdobry jmdobry deleted the tswast-patch-1 branch June 13, 2018 20:41
@snyk-bot snyk-bot mentioned this pull request Sep 5, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2022
Open
grayside pushed a commit that referenced this pull request Oct 26, 2022
@release-please
chore: release 2.3.4 (#545)
193784c 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.4](https://www.github.com/googleapis/nodejs-tasks/compare/v2.3.3...v2.3.4) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#543](https://www.github.com/googleapis/nodejs-tasks/issues/543)) ([d1a715d](https://www.github.com/googleapis/nodejs-tasks/commit/d1a715d92e0136b1840798c2e122e165201715cd))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
grayside pushed a commit that referenced this pull request Nov 3, 2022
@release-please @grayside
chore: release 2.3.4 (#545)
23e2e7c 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.3.4](https://www.github.com/googleapis/nodejs-tasks/compare/v2.3.3...v2.3.4) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#543](https://www.github.com/googleapis/nodejs-tasks/issues/543)) ([d1a715d](https://www.github.com/googleapis/nodejs-tasks/commit/d1a715d92e0136b1840798c2e122e165201715cd))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 3.17.0 (#543)
954b85a 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 3.17.0 (#543)
7652334 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 3.17.0 (#543)
ad4a266 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 3.17.0 (#543)
f55fa4e 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@release-please
chore: release 3.17.0 (#543)
a79615a 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 16, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore: release 3.17.0 (#543)
e2a6837 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
kweinmeister pushed a commit that referenced this pull request Nov 18, 2022
@release-please
chore: release 3.3.0 (#544)
2847e9a 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.3.0](https://www.github.com/googleapis/nodejs-text-to-speech/compare/v3.2.7...v3.3.0) (2021-08-23)


### Features

* turns on self-signed JWT feature flag ([#543](https://www.github.com/googleapis/nodejs-text-to-speech/issues/543)) ([bd5ecd3](https://www.github.com/googleapis/nodejs-text-to-speech/commit/bd5ecd31f2cf39486b85c62e1f5d35850cde22b9))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@NimJay NimJay mentioned this pull request Nov 19, 2022
Merged
NimJay pushed a commit that referenced this pull request Nov 19, 2022
@gcf-owl-bot
feat: add Dataproc Serverless for Spark Batches API (#543)
0244cc1 
Committer: @medb
PiperOrigin-RevId: 402631995
Source-Link: googleapis/googleapis@95af2e4
Source-Link: https://github.com/googleapis/googleapis-gen/commit/0ee7abd9ecd2951e958303681a4b251a948107b6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGVlN2FiZDllY2QyOTUxZTk1ODMwMzY4MWE0YjI1MWE5NDgxMDdiNiJ9
NimJay pushed a commit that referenced this pull request Nov 19, 2022
@release-please
chore: release 3.1.0 (#544)
3189b48 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.1.0](https://www.github.com/googleapis/nodejs-dataproc/compare/v3.0.0...v3.1.0) (2021-10-13)


### Features

* add Dataproc Serverless for Spark Batches API ([#543](https://www.github.com/googleapis/nodejs-dataproc/issues/543)) ([012b56f](https://www.github.com/googleapis/nodejs-dataproc/commit/012b56fd656b22fe555c9edafbfb9a8f20c91358))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
NimJay pushed a commit that referenced this pull request Nov 19, 2022
@gcf-owl-bot @NimJay
feat: add Dataproc Serverless for Spark Batches API (#543)
946db12 
Committer: @medb
PiperOrigin-RevId: 402631995
Source-Link: googleapis/googleapis@95af2e4
Source-Link: googleapis/googleapis-gen@0ee7abd
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGVlN2FiZDllY2QyOTUxZTk1ODMwMzY4MWE0YjI1MWE5NDgxMDdiNiJ9
NimJay pushed a commit that referenced this pull request Nov 19, 2022
@release-please @NimJay
chore: release 3.1.0 (#544)
7eaf50d 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.1.0](https://www.github.com/googleapis/nodejs-dataproc/compare/v3.0.0...v3.1.0) (2021-10-13)


### Features

* add Dataproc Serverless for Spark Batches API ([#543](https://www.github.com/googleapis/nodejs-dataproc/issues/543)) ([012b56f](https://www.github.com/googleapis/nodejs-dataproc/commit/012b56fd656b22fe555c9edafbfb9a8f20c91358))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@ninadhatkar ninadhatkar mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gguuss gguuss gguuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tswast @googlebot @gguuss