Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link for prerequisites #587

Merged
merged 2 commits into from
Apr 11, 2018
Merged

Fix link for prerequisites #587

merged 2 commits into from
Apr 11, 2018

Conversation

campionfellin
Copy link
Contributor

@campionfellin campionfellin commented Mar 29, 2018 •
edited by dpebot
Loading

This fixes issue #586

@codecov
Copy link

codecov bot commented Mar 30, 2018 •
edited
Loading

Codecov Report

Merging #587 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #587   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           3      3           
=====================================
  Hits            3      3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c625e...a94c87c. Read the comment docs.

@ace-n
Copy link
Contributor

ace-n commented Mar 30, 2018

@dpebot merge when green

@dpebot
Copy link
Contributor

dpebot commented Mar 30, 2018

Okay! I'll merge when all statuses are green and all reviewers approve.

@dpebot dpebot added the automerge Merge the pull request once unit tests and other checks pass. label Mar 30, 2018
@dpebot dpebot self-assigned this Mar 30, 2018
ace-n
ace-n suggested changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the changes to functions/helloworld/test/*?

(Any fixes to the CI system should be done outside of this PR.)

@campionfellin
Copy link
Contributor Author

Sorry about that, meant to do it in a separate branch.

@ace-n
Copy link
Contributor

ace-n commented Apr 11, 2018

Merging - CI failure is unrelated and I verified this manually.

@ace-n ace-n merged commit a3b5994 into GoogleCloudPlatform:master Apr 11, 2018
This was referenced Dec 23, 2020
Open
Open
This was referenced Sep 2, 2021
Open
Open
Open
This was referenced Jan 12, 2022
Open
Open
This was referenced Feb 10, 2022
Open
Open
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
samples(tests): added retry logic to flaky batch tests (#587)
39adafb
@ace-n ace-n mentioned this pull request Nov 17, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
samples(tests): added retry logic to flaky batch tests (#587)
d200bbe
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
samples(tests): added retry logic to flaky batch tests (#587)
14f8b4e
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
samples(tests): added retry logic to flaky batch tests (#587)
09744ef
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@munkhuushmgl
samples(tests): added retry logic to flaky batch tests (#587)
1f52827
This was referenced Nov 28, 2023
Open
Open
This was referenced Nov 30, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n requested changes

Assignees

@dpebot dpebot

Labels
automerge Merge the pull request once unit tests and other checks pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@campionfellin @ace-n @dpebot