Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kokoro config for standard environment #648

Closed
wants to merge 1 commit into from

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Jun 6, 2018

Add test config for appengine/datastore/standard.

Add test config for appengine/datastore/standard.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 6, 2018
@fhinkel fhinkel requested a review from tbpg June 6, 2018 22:09
@codecov
Copy link

codecov bot commented Jun 6, 2018

Codecov Report

Merging #648 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #648   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e9940a...94a2187. Read the comment docs.

# Format: //devtools/kokoro/config/proto/build.proto

# Download secrets from Cloud Storage.
gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/nodejs-docs-samples"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be moved to a common.cfg file, then it wouldn't need to be copied into every .cfg file.

@@ -0,0 +1,16 @@
# Format: //devtools/kokoro/config/proto/build.proto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea (feel free to ignore): maybe create an appengine directory to make things a little easier to find?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to add a few tests first to make sure they run as expected. And then worry about duplication and folders.

@fhinkel fhinkel added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 7, 2018
@fhinkel
Copy link
Contributor Author

fhinkel commented Jun 12, 2018

Close in favor of #652

@fhinkel fhinkel closed this Jun 12, 2018
@jmdobry jmdobry deleted the datastore-standard-kokoro branch June 27, 2018 22:25
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
Source-Link: googleapis/synthtool@d229a12
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:74ab2b3c71ef27e6d8b69b1d0a0c9d31447777b79ac3cd4be82c265b45f37e5e
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
Source-Link: googleapis/synthtool@d229a12
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:74ab2b3c71ef27e6d8b69b1d0a0c9d31447777b79ac3cd4be82c265b45f37e5e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants