Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need for the --disable-setuid-sandbox flag #654

Merged
merged 2 commits into from
Jun 12, 2018
Merged

No need for the --disable-setuid-sandbox flag #654

merged 2 commits into from
Jun 12, 2018

Conversation

glaforge
Copy link
Contributor

It seems the --disable-setuid-sandbox flag is becoming deprecating and is being removed from the Chrome codebase.
I tried running the sample without this flag, and the screenshots are properly generated.

/cc @steren

@glaforge
No need for the --disable-setuid-sandbox flag
1f1f3c7 
It seems the --disable-setuid-sandbox flag is becoming deprecating and is being removed from the Chrome codebase.
I tried running the sample without this flag, and the screenshots are properly generated.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 12, 2018
@steren
Copy link
Contributor

steren commented Jun 12, 2018

Thanks!

@codecov
Copy link

codecov bot commented Jun 12, 2018 •
edited
Loading

Codecov Report

Merging #654 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #654   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e87ca...d2c1ef6. Read the comment docs.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 12, 2018
@fhinkel fhinkel added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 12, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

MylesBorins
MylesBorins reviewed Jun 12, 2018
View reviewed changes
appengine/headless-chrome/app.js
@@ -29,7 +29,7 @@ app.use(async (req, res) => {

// [START browser]
const browser = await puppeteer.launch({
args: ['--no-sandbox', '--disable-setuid-sandbox']
args: ['--no-sandbox']
Copy link
Contributor

@MylesBorins MylesBorins Jun 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has this been confirmed in a deplyoment? If I recall the setuid-sandbox was necessary on standard (this was due to the user in standard by default being root, which was disallowed by puppeteer without this flag)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are green with and without the flag. @steren, how much confidence do you have in your test? 😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it manually on standard. Works fine without the flag.

@fhinkel fhinkel merged commit 0f41e30 into GoogleCloudPlatform:master Jun 12, 2018
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@aaronlichen-hp @gcf-owl-bot
feat: add batchGetEffectiveIamPolicies sample code. (#654)
7ba8cfb 
* feat: add batchGetEffectiveIamPolicies sample code.

Add batchGetEffectiveIamPolicies sample code and also lint the protobuf
imports.

* chore: fix the Copyright year for getBatchEffectiveIamPolicies.js

* chore: refactor logging and remove loop for checking results

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: modify the logging to print nested Object.

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@aaronlichen-hp @gcf-owl-bot
feat: add batchGetEffectiveIamPolicies sample code. (#654)
f2b64fb 
* feat: add batchGetEffectiveIamPolicies sample code.

Add batchGetEffectiveIamPolicies sample code and also lint the protobuf
imports.

* chore: fix the Copyright year for getBatchEffectiveIamPolicies.js

* chore: refactor logging and remove loop for checking results

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: modify the logging to print nested Object.

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@aaronlichen-hp @gcf-owl-bot
feat: add batchGetEffectiveIamPolicies sample code. (#654)
273d0e7 
* feat: add batchGetEffectiveIamPolicies sample code.

Add batchGetEffectiveIamPolicies sample code and also lint the protobuf
imports.

* chore: fix the Copyright year for getBatchEffectiveIamPolicies.js

* chore: refactor logging and remove loop for checking results

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: modify the logging to print nested Object.

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@aaronlichen-hp @gcf-owl-bot
feat: add batchGetEffectiveIamPolicies sample code. (#654)
15298d9 
* feat: add batchGetEffectiveIamPolicies sample code.

Add batchGetEffectiveIamPolicies sample code and also lint the protobuf
imports.

* chore: fix the Copyright year for getBatchEffectiveIamPolicies.js

* chore: refactor logging and remove loop for checking results

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: modify the logging to print nested Object.

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
@aaronlichen-hp @gcf-owl-bot
feat: add batchGetEffectiveIamPolicies sample code. (#654)
9d7be56 
* feat: add batchGetEffectiveIamPolicies sample code.

Add batchGetEffectiveIamPolicies sample code and also lint the protobuf
imports.

* chore: fix the Copyright year for getBatchEffectiveIamPolicies.js

* chore: refactor logging and remove loop for checking results

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: modify the logging to print nested Object.

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 16, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@aaronlichen-hp @gcf-owl-bot
feat: add batchGetEffectiveIamPolicies sample code. (#654)
231b118 
* feat: add batchGetEffectiveIamPolicies sample code.

Add batchGetEffectiveIamPolicies sample code and also lint the protobuf
imports.

* chore: fix the Copyright year for getBatchEffectiveIamPolicies.js

* chore: refactor logging and remove loop for checking results

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: modify the logging to print nested Object.

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@leejh3224 leejh3224 mentioned this pull request Jul 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins left review comments

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glaforge @steren @googlebot @fhinkel @MylesBorins