Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (missing) Node 8 unit tests #695

Merged
merged 2 commits into from
Jul 23, 2018
Merged

Add (missing) Node 8 unit tests #695

merged 2 commits into from
Jul 23, 2018

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Jul 23, 2018

FYI @carieshmarie - existing integration/system tests should work with both Node versions

@ace-n ace-n added the GCF Docs label Jul 23, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2018
@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #695 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #695   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1845478...4976d12. Read the comment docs.

@ace-n ace-n merged commit 29f1230 into master Jul 23, 2018
@ace-n ace-n deleted the node8-tests branch July 23, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants