Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KMS] Generalizing KMS samples for GCS docs #708

Merged
merged 1 commit into from
Aug 13, 2018
Merged

[KMS] Generalizing KMS samples for GCS docs #708

merged 1 commit into from
Aug 13, 2018

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Aug 10, 2018

Hi,

I'm removing global location mention to generalize sample for GCS CMEK documentation. The sample is used to show developers how to set an IAM policy on a KMS key, but global location aren't supported so I' want to generalize that part of the sample.

PTAL, thank you!

@frankyn frankyn requested a review from jmdobry August 10, 2018 23:35
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2018
@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #708 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #708   +/-   ##
=======================================
  Coverage   55.17%   55.17%           
=======================================
  Files           1        1           
  Lines          58       58           
=======================================
  Hits           32       32           
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c26c5d7...8927cf7. Read the comment docs.

@frankyn
Copy link
Member Author

frankyn commented Aug 10, 2018

Thanks @JustinBeckwith

@frankyn
Copy link
Member Author

frankyn commented Aug 13, 2018

Merging as failed test is not related to this sample. (Cloud SQL for PostgreSQL failure)

@frankyn frankyn merged commit ca35cff into master Aug 13, 2018
@frankyn frankyn deleted the kms-for-gcs branch August 13, 2018 16:02
ace-n pushed a commit that referenced this pull request Nov 17, 2022
Change-Id: I4e604288729e77a2bc8a31c749a89ee662cb3ff8

Fixes #698  🦕
ace-n pushed a commit that referenced this pull request Nov 17, 2022
Change-Id: I4e604288729e77a2bc8a31c749a89ee662cb3ff8

Fixes #698  🦕
ace-n pushed a commit that referenced this pull request Nov 17, 2022
Change-Id: I4e604288729e77a2bc8a31c749a89ee662cb3ff8

Fixes #698  🦕
ace-n pushed a commit that referenced this pull request Nov 17, 2022
Change-Id: I4e604288729e77a2bc8a31c749a89ee662cb3ff8

Fixes #698  🦕
ace-n pushed a commit that referenced this pull request Nov 17, 2022
Change-Id: I4e604288729e77a2bc8a31c749a89ee662cb3ff8

Fixes #698  🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants