Fix busboy + GCF race condition #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ace-n
commented
Aug 17, 2018
| @@ -166,24 +166,42 @@ exports.uploadFile = (req, res) => { | |||
| fields[fieldname] = val; | |||
| }); | |||
|
|
|||
| let fileWrites = []; | |||
There was a problem hiding this comment.
Nit: should this be const?
There was a problem hiding this comment.
I think our linter would complain.
Codecov Report
@@ Coverage Diff @@
## master #713 +/- ##
=======================================
Coverage 55.17% 55.17%
=======================================
Files 1 1
Lines 58 58
=======================================
Hits 32 32
Misses 26 26Continue to review full report at Codecov.
|
fhinkel
approved these changes
Aug 20, 2018
This was referenced Jan 31, 2020
This was referenced Apr 7, 2022
Open
Open
Open
Open
Open
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
This was referenced Nov 14, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 21, 2022
Shabirmean
pushed a commit
that referenced
this pull request
Feb 16, 2023
* build!: Update library to use Node 12 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I wanted this to be Node
6.xcompliant, so I avoided usingasync/awaitin favor of Promises.