Add node8 firebase snippets #719
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
=======================================
Coverage 55.17% 55.17%
=======================================
Files 1 1
Lines 58 58
=======================================
Hits 32 32
Misses 26 26Continue to review full report at Codecov.
|
functions/node8/index.js
Outdated
|
|
||
| // [START functions_firebase_auth_node8] | ||
| /** | ||
| * Triggered by a change to a Firebase Auth user object. |
There was a problem hiding this comment.
Same comment as before: it's only creation or deletion, not a change.
| const triggerResource = context.resource; | ||
|
|
||
| console.log(`Function triggered by change to: ${triggerResource}`); | ||
| console.log(`Admin?: ${!!data.admin}`); |
There was a problem hiding this comment.
@stew-r is this correct, or will data.admin always be undefined?
ace-n
added
the
do not merge
|
TODO: add tests |
ace-n
removed
the
do not merge
|
Tests have been added - @fhinkel please review? |
| console.log(`Function triggered by change to: ${triggerResource}`); | ||
|
|
||
| console.log(`\nOld value:`); | ||
| console.log(JSON.stringify(data.oldValue, null, 2)); |
There was a problem hiding this comment.
Is the double space necessary? I personally would prefer shorter code without the extra params.
There was a problem hiding this comment.
Not strictly necessary, but makes it easier to read. (Without it, everything is compressed into one line.)
functions/node8/package.json
Outdated
| @@ -19,7 +19,9 @@ | |||
| "url": "https://github.com/GoogleCloudPlatform/nodejs-docs-samples/issues" | |||
| }, | |||
| "dependencies": { | |||
| "ava": "^0.25.0" | |||
| "@google-cloud/nodejs-repo-tools": "^2.3.3", | |||
There was a problem hiding this comment.
repo-tools and ava should be dev dependencies.
functions/node8/test/index.test.js
Outdated
| 'use strict'; | ||
|
|
||
| const uuid = require('uuid'); | ||
| const test = require(`ava`); |
* Add node8 firebase snippets * Address sam's comments * Add (unit) tests for Firebase snippets * Move deps to devDeps * Fix quotes
cc @stew-r @samtstern