Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memorystore GCE : Replace GCS_APP_LOCATION with GCS_BUCKET_NAME #728

Merged
merged 4 commits into from
Sep 7, 2018

Conversation

jabubake
Copy link
Contributor

No description provided.

@jabubake jabubake requested a review from kurtisvg August 31, 2018 23:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2018
@jabubake jabubake requested a review from fhinkel August 31, 2018 23:33
@jabubake
Copy link
Contributor Author

@fhinkel : the failures don't seem related to my PR. What's the best path forward ?

@kurtisvg
Copy link
Contributor

kurtisvg commented Sep 5, 2018

@fhinkel What can we do to get this merged? It is blocking a CL to update the documentation.

@fhinkel
Copy link
Contributor

fhinkel commented Sep 7, 2018

So sorry, completely missed this. Looking at it now

@fhinkel
Copy link
Contributor

fhinkel commented Sep 7, 2018

@ace-n , please merge this once you've fixed the test config. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants