Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud Healthcare API alpha HL7v2 samples and tests #881

Merged
merged 19 commits into from
Nov 13, 2018
Merged

Cloud Healthcare API alpha HL7v2 samples and tests #881

merged 19 commits into from
Nov 13, 2018

Conversation

noerog
Copy link
Contributor

@noerog noerog commented Nov 12, 2018

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2018
fhinkel
fhinkel approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small comment

healthcare/hl7v2/package.json Outdated Show resolved Hide resolved
@noerog noerog changed the title Cloud Healthcare API alpha HL7v2 samples Cloud Healthcare API alpha HL7v2 samples and tests Nov 12, 2018
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 13, 2018
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 13, 2018
@noerog
Fix lint error
4b98b93 
  219:11  error  'results' is defined but never used  no-unused-vars
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 13, 2018
noerog and others added 11 commits November 13, 2018 14:07
@noerog
Cloud Healthcare API alpha HL7v2 samples
2bf825e
@JustinBeckwith @noerog
Remove empty App Engine tutorials (#874)
a98b1e4
@fhinkel @noerog
Update jobs sample (#880)
4f22ffe 
Update googleapis, use current auth.

Refs: #878
@oluomoniyi @noerog
Fix params sent to ga endpoint (#585)
71f0aba
@fhinkel @noerog
Update googleapis and auth (#882)
5c7bc4c
@fhinkel @noerog
Delete grunt sample (#883)
b43d56e 
We don't have a grunt + express sample in our docs anymore.
@fhinkel @noerog
Run eslint on most samples (#884)
fc9d1e8 
Fixes: #836
Fixes: #839
@ericschmidtatwork @noerog
GCF: Add Node 8 background function samples (#779)
4c4ebe3 
* GCF: Add Node 8 background function samples

* Add necessary dependencies to package.json

* GCF: Add Node 8 background function samples

* Add necessary dependencies to package.json

* Add tests + switch to requestPromiseNative/mocking

* Fix lint bugs caused by merge
@noerog
Try to fix lint error again
890ed30
@noerog
Fix lint errors from npm run lint -- --fix
20c5c80
@noerog
Merge branch 'master' into chc-api-hl7v2
60aceb1
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 13, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 13, 2018
@fhinkel fhinkel added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2018
@fhinkel fhinkel added kokoro:run Add this label to force Kokoro to re-run the tests. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 13, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@fhinkel fhinkel merged commit cb38ff0 into GoogleCloudPlatform:master Nov 13, 2018
This was referenced Oct 7, 2020
Open
Open
Open
Open
This was referenced Aug 29, 2021
Open
Open
Open
Open
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please @gcf-owl-bot @sofisl
chore(main): release 7.0.4 (#881)
1700d67 
* chore(main): release 7.0.4

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
@ace-n ace-n mentioned this pull request Nov 17, 2022
Merged
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please @gcf-owl-bot @sofisl
chore(main): release 7.0.4 (#881)
36823a0 
* chore(main): release 7.0.4

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please @gcf-owl-bot @sofisl
chore(main): release 7.0.4 (#881)
b56b16d 
* chore(main): release 7.0.4

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please @gcf-owl-bot @sofisl
chore(main): release 7.0.4 (#881)
cb45481 
* chore(main): release 7.0.4

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
renovate-bot pushed a commit to renovate-bot/nodejs-docs-samples that referenced this pull request Nov 17, 2022
@release-please @gcf-owl-bot @sofisl
chore(main): release 7.0.4 (GoogleCloudPlatform#881)
c83e032 
* chore(main): release 7.0.4

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@release-please
chore: release 4.5.0 (#881)
43c343e 
🤖 I have created a release \*beep\* \*boop\*
---
## [4.5.0](https://www.github.com/googleapis/nodejs-dialogflow/compare/v4.4.0...v4.5.0) (2021-10-11)


### Features

* added support for TelephonyTransferCall in Participant ResponseMessage ([#880](https://www.github.com/googleapis/nodejs-dialogflow/issues/880)) ([dbcf3b0](https://www.github.com/googleapis/nodejs-dialogflow/commit/dbcf3b087cf141f88af5406bd9c1ae92f1c16e19))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 18, 2022
@release-please
chore: release 4.5.0 (#881)
a8a1ada 
🤖 I have created a release \*beep\* \*boop\*
---
## [4.5.0](https://www.github.com/googleapis/nodejs-dialogflow/compare/v4.4.0...v4.5.0) (2021-10-11)


### Features

* added support for TelephonyTransferCall in Participant ResponseMessage ([#880](https://www.github.com/googleapis/nodejs-dialogflow/issues/880)) ([dbcf3b0](https://www.github.com/googleapis/nodejs-dialogflow/commit/dbcf3b087cf141f88af5406bd9c1ae92f1c16e19))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@ahrarmonsur ahrarmonsur mentioned this pull request Nov 18, 2022
Merged
NimJay pushed a commit that referenced this pull request Nov 18, 2022
@release-please @NimJay
chore: release 4.5.0 (#881)
97a2cd7 
🤖 I have created a release \*beep\* \*boop\*
---
## [4.5.0](https://www.github.com/googleapis/nodejs-dialogflow/compare/v4.4.0...v4.5.0) (2021-10-11)


### Features

* added support for TelephonyTransferCall in Participant ResponseMessage ([#880](https://www.github.com/googleapis/nodejs-dialogflow/issues/880)) ([dbcf3b0](https://www.github.com/googleapis/nodejs-dialogflow/commit/dbcf3b087cf141f88af5406bd9c1ae92f1c16e19))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@noerog @googlebot @fhinkel @kokoro-team @JustinBeckwith @oluomoniyi @ericschmidtatwork