Compute Engine samples #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * @param {Function} callback Callback function. | ||
| */ | ||
| function getVmsExample(callback) { |
There was a problem hiding this comment.
This looks the same as the example above, just using the api client instead of gcloud. Why?
|
LGTM |
| "node": ">=0.10.x" | ||
| }, | ||
| "scripts": { | ||
| "sendgrid": "node sendgrid.js", |
There was a problem hiding this comment.
nothing in this sample is really compute engine specific - at what point do we just have a single sendgrid sample, and use that for g[cka]e?
There was a problem hiding this comment.
Just realized that wasn't a yes/no question. 😆
sethbergman
pushed a commit
to stackriot/nodejs-docs-samples
that referenced
this pull request
Jun 4, 2017
* Fix E2E test failure * Make tests more concise * Fix lint * Make tests faster + add console.log calls * Use updated nodejs-repo-tools in package.json * Don't delete apps after they are deployed * Move tests to appspot-preview.com * Add sub-dependencies to main package.json file (so Jenkins recognizes them) * Unpin nodejs-repo-tools dependency * Ignore yarn lockfiles * TODO DEBUG COMMIT - change location of nodejs-repo-tools * Put each test on a different port * Switch to yarn + unified dependency model * Update lockfile * Update unify script * Add yarn to Travis + debug yarn install * Fix lint
ivanmkc
pushed a commit
that referenced
this pull request
Nov 3, 2022
grayside
pushed a commit
that referenced
this pull request
Nov 8, 2022
telpirion
pushed a commit
that referenced
this pull request
Nov 9, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
telpirion
pushed a commit
that referenced
this pull request
Nov 9, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
pattishin
pushed a commit
that referenced
this pull request
Nov 9, 2022
pattishin
pushed a commit
that referenced
this pull request
Nov 9, 2022
pattishin
pushed a commit
that referenced
this pull request
Nov 9, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 10, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 10, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 11, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 18, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 18, 2022
jsimonweb
pushed a commit
to jsimonweb/nodejs-docs-samples
that referenced
this pull request
Dec 12, 2022
Shabirmean
pushed a commit
that referenced
this pull request
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.