Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding more assertions to testOozieExamples, fixes #264 #284

Merged
merged 1 commit into from
Jul 3, 2019
Merged

adding more assertions to testOozieExamples, fixes #264 #284

merged 1 commit into from
Jul 3, 2019

Conversation

LeonardoFurtado
Copy link

Make sure you have checked all steps below and that above description is correct.

JIRA

  • My PR addresses the following Issue
    issue and references it in commit message.

Tests

  • My PR has unit tests testing the functionality (or I explained why it needs no tests)

Commits

  • My commits reference the issue in the message using: Fixes #XXX /Closes #XXX or similar.

@mik-laj
Copy link
Collaborator

mik-laj commented Jul 3, 2019

Hi,

Thanks very much for this PR. I started the job on Travis with this change.
https://travis-ci.org/GoogleCloudPlatform/oozie-to-airflow/builds/553850219
When the job is completed, I will merge a change to the project.

I have another task for you. This is a bit harder.
#266
Do you want to take it?

@LeonardoFurtado
Copy link
Author

Yes I do. If i have any questions about what to do in #266 can I leave a comment on it? I intend to continue contributing whenever possible, over time I will better understand the structure of the project.

@mik-laj mik-laj merged commit e8be206 into GoogleCloudPlatform:master Jul 3, 2019
@mik-laj
Copy link
Collaborator

mik-laj commented Jul 3, 2019

Yes. You can ask questions on the issues.

I'm also available on Slack - Apache Airflow. https://apache-airflow-slack.herokuapp.com/ I'm Kamil Breguła on this slack, but i prefer discussion over issues.

@sprzedwojski
Copy link
Contributor

Hi @LeonardoFurtado! I just wanted to say "welcome" in our small community from my part as another contributor to this project. 👋 Thank you for your work so far, good job! 💪
Like @mik-laj said, if you have any questions - don't hesitate to ask under issues.
I am looking forward to your future PRs! 😃

@LeonardoFurtado
Copy link
Author

Hi @sprzedwojski ! Thank you for your very friendly welcome. I was looking for some project that I can contribute, I believe it can be a good experience for me as a student. I will start the solution for issue #266 today. Thanks again. <3

ahidalgob pushed a commit that referenced this pull request Sep 22, 2023
GitOrigin-RevId: 22b59362a524e3c941053ba0bd5c58a04de64d93
Change-Id: I71973cf215521d9186ea546e4ceedc173b0de9b1
ahidalgob pushed a commit that referenced this pull request Sep 22, 2023
GitOrigin-RevId: 22b59362a524e3c941053ba0bd5c58a04de64d93
Change-Id: I71973cf215521d9186ea546e4ceedc173b0de9b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants