add host.id as a fallback for instance

GoogleCloudPlatform · May 22, 2024 · 9db9356 · 9db9356
1 parent f2ec3e7
commit 9db9356
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/exporter/collector/googlemanagedprometheus/monitoredresource.go b/exporter/collector/googlemanagedprometheus/monitoredresource.go
@@ -71,6 +71,7 @@ var promTargetKeys = map[string][]string{
 		semconv.AttributeServiceInstanceID,
 		semconv.AttributeFaaSInstance,
 		semconv.AttributeK8SPodName,
+		semconv.AttributeHostID,
 	},
 }
 

diff --git a/exporter/collector/googlemanagedprometheus/monitoredresource_test.go b/exporter/collector/googlemanagedprometheus/monitoredresource_test.go
@@ -320,10 +320,10 @@ func TestMapToPrometheusTarget(t *testing.T) {
 		{
 			desc: "Attributes from GCE with environment label",
 			resourceLabels: map[string]string{
-				"cloud.platform":      "gcp_compute_engine",
-				"cloud.region":        "us-central1",
-				"service.name":        "service-name",
-				"service.instance.id": "1234759430923053489543203",
+				"cloud.platform": "gcp_compute_engine",
+				"cloud.region":   "us-central1",
+				"service.name":   "service-name",
+				"host.id":        "1234759430923053489543203",
 			},
 			expected: &monitoredrespb.MonitoredResource{
 				Type: "prometheus_target",