Update GCE Beyla sample to use config file #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psx95
force-pushed
the
update-beyla-gce-sample
branch
from
ba16459 to
932dc57
Compare
dashpole
reviewed
Aug 5, 2024
dashpole
approved these changes
Aug 5, 2024
Co-authored-by: David Ashpole <dashpole@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the sample to use a config file instead of environment variables. Config file can be used to specify service discovery section, which allows the user to group multiple services running on the same VM instance in a single namespace and also provide names to services based on their
exe_path.Note: Environment variables can be used in combination with the config-file, but have been removed in this PR to avoid confusion.
Testing