-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move cAdvisor prow config from k8s.io #336
Conversation
Hi @dashpole. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dashpole The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following users are mentioned in OWNERS file(s) but are not members of the GoogleCloudPlatform org. Once all users have been added as members of the org, you can trigger verification by writing
|
/assign |
# See the OWNERS docs at https://go.k8s.io/owners | ||
|
||
approvers: | ||
- dashpole |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you joined GCP org yet?
/retest |
@dashpole: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
cc @bobbypage @SergeyKanzhelev @dims I'm not going to be able to complete this. Depending on whether or not cAdvisor is moved somewhere else, this may or may not be neccessary. |
Let me know if there is anything else required. I haven't checked that this works, so it may need further changes.
kubernetes/test-infra#12863
/assign @krzyzacy