Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cAdvisor prow config from k8s.io #336

Closed
wants to merge 1 commit into from

Conversation

dashpole
Copy link

Let me know if there is anything else required. I haven't checked that this works, so it may need further changes.

kubernetes/test-infra#12863

/assign @krzyzacy

@google-oss-robot
Copy link
Collaborator

Hi @dashpole. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dashpole
To complete the pull request process, please assign katharine
You can assign the PR to them by writing /assign @katharine in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link
Collaborator

The following users are mentioned in OWNERS file(s) but are not members of the GoogleCloudPlatform org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • dashpole
    • prow/prowjobs/google/cadvisor/OWNERS

@fejta
Copy link
Contributor

fejta commented Apr 21, 2020

/assign
/ok-to-test

# See the OWNERS docs at https://go.k8s.io/owners

approvers:
- dashpole
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you joined GCP org yet?

@fejta
Copy link
Contributor

fejta commented Jul 24, 2020

/retest

@google-oss-robot
Copy link
Collaborator

@dashpole: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-oss-test-infra-check-testgrid-config 590398c link /test pull-oss-test-infra-check-testgrid-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dashpole
Copy link
Author

dashpole commented Nov 2, 2020

cc @bobbypage @SergeyKanzhelev @dims

I'm not going to be able to complete this. Depending on whether or not cAdvisor is moved somewhere else, this may or may not be neccessary.

@dashpole dashpole closed this Nov 2, 2020
@dashpole dashpole deleted the cadvisor branch November 2, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants