Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add MR CMEK samples #2044

Merged
merged 39 commits into from
Oct 18, 2024

Conversation

panerorenn9541
Copy link
Contributor

Add samples and tests for create database, create backup, copy backup, and restore backup.

@panerorenn9541 panerorenn9541 requested review from a team as code owners August 28, 2024 15:49
Copy link

snippet-bot bot commented Aug 28, 2024

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels Aug 28, 2024
spanner/src/copy_backup_with_MR_CMEK.php Outdated Show resolved Hide resolved
spanner/src/copy_backup_with_MR_CMEK.php Outdated Show resolved Hide resolved
@Hectorhammett
Copy link
Collaborator

Looking good but there are some errors on the syntax and style on the tests :).

spanner/src/copy_backup_with_MR_CMEK.php Outdated Show resolved Hide resolved
spanner/src/create_backup_with_MR_CMEK.php Outdated Show resolved Hide resolved
bshaffer and others added 7 commits October 8, 2024 09:50
…h_mr_cmek.php

Change from MR_CMEK to mr_cmek
…_with_mr_cmek.php

Change from MR_CMEK to mr_cmek
…ith_mr_cmek.php

Change from MR_CMEK to mr_cmek
Change from MR_CMEK to mr_cmek
Change from MR_CMEK to mr_cmek
@bshaffer bshaffer enabled auto-merge (squash) October 15, 2024 20:39
Add self::$ to kmsKeyName
auto-merge was automatically disabled October 16, 2024 00:31

Head branch was pushed to by a user without write access

@Hectorhammett Hectorhammett merged commit 5ad66db into GoogleCloudPlatform:main Oct 18, 2024
2 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants