Proof of concept for macro-benchmarking automation #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adib234
commented
Jun 10, 2024
scripts/deploy_parca.sh
Outdated
|
|
||
| # Cleanup | ||
| kill %1 # Terminate the background port-forward process | ||
| kubectl delete all --all --all-namespaces |
Adib234
commented
Jun 10, 2024
scripts/deploy_parca.sh
Outdated
|
|
||
|
|
||
| # Create GKE cluster | ||
| gcloud beta container --project "lees-gmp" clusters create "parca-cluster" --zone "us-central1-c" --no-enable-basic-auth --cluster-version "1.28.9-gke.1000000" --release-channel "regular" --machine-type "e2-medium" --image-type "COS_CONTAINERD" --disk-type "pd-balanced" --disk-size "100" --metadata disable-legacy-endpoints=true --scopes "https://www.googleapis.com/auth/devstorage.read_only","https://www.googleapis.com/auth/logging.write","https://www.googleapis.com/auth/monitoring","https://www.googleapis.com/auth/servicecontrol","https://www.googleapis.com/auth/service.management.readonly","https://www.googleapis.com/auth/trace.append" --num-nodes "3" --logging=SYSTEM,WORKLOAD --monitoring=SYSTEM --enable-ip-alias --network "projects/lees-gmp/global/networks/lees-network" --subnetwork "projects/lees-gmp/regions/us-central1/subnetworks/lees-network" --no-enable-intra-node-visibility --default-max-pods-per-node "110" --security-posture=standard --workload-vulnerability-scanning=disabled --no-enable-master-authorized-networks --addons HorizontalPodAutoscaling,HttpLoadBalancing,GcePersistentDiskCsiDriver --enable-autoupgrade --enable-autorepair --max-surge-upgrade 1 --max-unavailable-upgrade 0 --binauthz-evaluation-mode=DISABLED --no-enable-managed-prometheus --enable-shielded-nodes --node-locations "us-central1-c" |
There was a problem hiding this comment.
need a better way to create a cluster
Adib234
commented
Jun 10, 2024
scripts/deploy_parca.sh
Outdated
| # Port-forward Parca service to see visualization system | ||
| kubectl -n parca port-forward service/parca 7070 & | ||
|
|
||
| sleep 1800 |
There was a problem hiding this comment.
I think this might need to get changed because Bartek said something about parca being left running for 2 weeks?
Adib234
commented
Jun 10, 2024
| - "--native-histogram-count=1" | ||
| - "--gauge-count=2" | ||
| - "--counter-count=2" | ||
| - "--summary-count=2" | ||
| env: |
There was a problem hiding this comment.
these changes exist because we want the prometheus instance to scrape metrics from go-synthetic
pintohutch
requested changes
Jun 11, 2024
|
|
||
|
|
||
| # Create GKE cluster | ||
| gcloud beta container --project "lees-gmp" clusters create "parca-cluster" --zone "us-central1-c" --no-enable-basic-auth --cluster-version "1.28.9-gke.1000000" --release-channel "regular" --machine-type "e2-medium" --image-type "COS_CONTAINERD" --disk-type "pd-balanced" --disk-size "100" --metadata disable-legacy-endpoints=true --scopes "https://www.googleapis.com/auth/devstorage.read_only","https://www.googleapis.com/auth/logging.write","https://www.googleapis.com/auth/monitoring","https://www.googleapis.com/auth/servicecontrol","https://www.googleapis.com/auth/service.management.readonly","https://www.googleapis.com/auth/trace.append" --num-nodes "3" --logging=SYSTEM,WORKLOAD --monitoring=SYSTEM --enable-ip-alias --network "projects/lees-gmp/global/networks/lees-network" --subnetwork "projects/lees-gmp/regions/us-central1/subnetworks/lees-network" --no-enable-intra-node-visibility --default-max-pods-per-node "110" --security-posture=standard --workload-vulnerability-scanning=disabled --no-enable-master-authorized-networks --addons HorizontalPodAutoscaling,HttpLoadBalancing,GcePersistentDiskCsiDriver --enable-autoupgrade --enable-autorepair --max-surge-upgrade 1 --max-unavailable-upgrade 0 --binauthz-evaluation-mode=DISABLED --no-enable-managed-prometheus --enable-shielded-nodes --node-locations "us-central1-c" |
There was a problem hiding this comment.
I don't believe GH has access to our gcloud projects. @maxamins do you recall what we did for prombench to get around this?
| @@ -0,0 +1,195 @@ | |||
| # Copyright 2024 Google LLC | |||
There was a problem hiding this comment.
suggestion: I would move these files out of manifests/.
manifests/ is a directory we reserve for users manually installing managed collection on K8s, which shouldn't include Parca right now :)
Maybe put it in hack/ or examples/ for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is give a sense of what's to come once I get into the implementation phase of my project and to get some initial thoughts. I also plan on using this branch as a sandbox to test some stuff for Github Actions.