fix: show warning when cleaning up old resources without delete permissions #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpiritXIII
force-pushed
the
TheSpiritXIII/delete-warning
branch
from
e242efb
to
e6652f3
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/delete-warning
branch
from
e6652f3
to
a8b63c8
Compare
bernot-dev
reviewed
Jul 31, 2024
pintohutch
approved these changes
Aug 2, 2024
TheSpiritXIII
force-pushed
the
TheSpiritXIII/delete-warning
branch
from
a8b63c8
to
ad80b61
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/delete-warning
branch
from
ad80b61
to
d93eea9
Compare
pintohutch
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the cleanup flag today causes the operator to crash-looping because we don't include the DELETE RBAC permission by default.
This happened because we used to do all resource creation/update/deletion on the operator but we moved it to YAML. This also makes the cleanup function consistent, as we warn when we can't delete everything else.