feat: allow loading rule-evaluator query options from config #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpiritXIII
force-pushed
the
TheSpiritXIII/rule-eval-runtime
branch
10 times, most recently
from
f235b4a
to
b6573e9
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/rule-eval-runtime
branch
3 times, most recently
from
9487d00
to
f2a7f9a
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/rule-eval-runtime
branch
from
f2a7f9a
to
efc2dc0
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/rule-eval-runtime
branch
6 times, most recently
from
5d46346
to
f2f236b
Compare
TheSpiritXIII
requested review from
bwplotka and
pintohutch
and removed request for
bwplotka
TheSpiritXIII
force-pushed
the
TheSpiritXIII/rule-eval-runtime
branch
2 times, most recently
from
74be4dd
to
d5b8f72
Compare
TheSpiritXIII
changed the base branch from
main
to
TheSpiritXIII/rule-export-runtime
TheSpiritXIII
force-pushed
the
TheSpiritXIII/rule-eval-runtime
branch
2 times, most recently
from
f1573e2
to
fd6303c
Compare
TheSpiritXIII
changed the title
TheSpiritXIII
force-pushed
the
TheSpiritXIII/rule-eval-runtime
branch
2 times, most recently
from
420e694
to
2a7865a
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/rule-export-runtime
branch
from
f1f97f8
to
515d45b
Compare
bwplotka
reviewed
Aug 23, 2024
bwplotka
reviewed
Aug 23, 2024
bwplotka
reviewed
Aug 23, 2024
| } | ||
|
|
||
| return &evaluator, nil | ||
| } | ||
|
|
||
| func (e *ruleEvaluator) ApplyConfig(cfg *config.Config) error { | ||
| func (e *ruleEvaluator) ApplyConfig(cfg *config.Config, evaluatorOpts *evaluatorOptions) error { | ||
| if evaluatorOpts != nil && !reflect.DeepEqual(evaluatorOpts, e.lastEvaluatorOpts) { |
There was a problem hiding this comment.
This is a bit of work that could be replaced by simply detecting change AND os.Exit(0) (with clear log AND metric ideally, AND do this in main ofc).
This has consequence of tricky to debug if the "restart" was actual crash or consequence of valid config changes, but potentially it's fine?
bwplotka
reviewed
Aug 23, 2024
cmd/rule-evaluator/main.go
Outdated
| for { | ||
| // Copy the rule-manager before running, so we don't hold the lock. | ||
| e.mtx.Lock() | ||
| oldRuleManager := e.rulesManager |
There was a problem hiding this comment.
I will think about perhaps if there's anything to simplify here
TheSpiritXIII
force-pushed
the
TheSpiritXIII/rule-export-runtime
branch
from
515d45b
to
bcc7f6a
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/rule-eval-runtime
branch
from
2a7865a
to
3db475a
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/rule-eval-runtime
branch
2 times, most recently
from
63d63a7
to
9d4a522
Compare
TheSpiritXIII
force-pushed
the
TheSpiritXIII/rule-eval-runtime
branch
from
9d4a522
to
70b228c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-req: #1104
The following are now settable in the rule-evaluator Prometheus config:
When both CLI arguments and configurations are present, the CLI arguments will be the default and the set configurations will override the CLI arguments.